* [PATCH] ahci: port_no should be used when clearing IRQ in ahci_thaw()
@ 2007-01-27 2:04 Tejun Heo
2007-01-27 7:54 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-01-27 2:04 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
ap->id is logcial port ID which is unique among all ATA ports and
doesn't have anything to do with hardware port index. ap->port_no is
the hardware port index and thus should be used when clearing IRQ mask
in ahci_thaw().
This problem has been spotted by Jeff Garzik <jgarzik@pobox.com>.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ab73b0a..7f1bf85 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1281,7 +1281,7 @@ static void ahci_thaw(struct ata_port *ap)
/* clear IRQ */
tmp = readl(port_mmio + PORT_IRQ_STAT);
writel(tmp, port_mmio + PORT_IRQ_STAT);
- writel(1 << ap->id, mmio + HOST_IRQ_STAT);
+ writel(1 << ap->port_no, mmio + HOST_IRQ_STAT);
/* turn IRQ back on */
writel(DEF_PORT_IRQ, port_mmio + PORT_IRQ_MASK);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ahci: port_no should be used when clearing IRQ in ahci_thaw()
2007-01-27 2:04 [PATCH] ahci: port_no should be used when clearing IRQ in ahci_thaw() Tejun Heo
@ 2007-01-27 7:54 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-01-27 7:54 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> ap->id is logcial port ID which is unique among all ATA ports and
> doesn't have anything to do with hardware port index. ap->port_no is
> the hardware port index and thus should be used when clearing IRQ mask
> in ahci_thaw().
>
> This problem has been spotted by Jeff Garzik <jgarzik@pobox.com>.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-27 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-27 2:04 [PATCH] ahci: port_no should be used when clearing IRQ in ahci_thaw() Tejun Heo
2007-01-27 7:54 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).