* [PATCH] libata: fix ata_eh_suspend() return value
@ 2007-01-26 11:10 Tejun Heo
2007-01-27 8:22 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-01-26 11:10 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
ata_eh_suspend() was returning 0 regardless of failure. This bug has
potential to lose data on suspend. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Jeff, this one is definitely for 2.6.20. Thanks.
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index eee3525..52c85af 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1791,7 +1791,7 @@ static int ata_eh_suspend(struct ata_port *ap, struct ata_device **r_failed_dev)
*r_failed_dev = dev;
DPRINTK("EXIT\n");
- return 0;
+ return rc;
}
/**
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: fix ata_eh_suspend() return value
2007-01-26 11:10 [PATCH] libata: fix ata_eh_suspend() return value Tejun Heo
@ 2007-01-27 8:22 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-01-27 8:22 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> ata_eh_suspend() was returning 0 regardless of failure. This bug has
> potential to lose data on suspend. Fix it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Jeff, this one is definitely for 2.6.20. Thanks.
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-27 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-26 11:10 [PATCH] libata: fix ata_eh_suspend() return value Tejun Heo
2007-01-27 8:22 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).