[PATCH] iomap: iomap should be in obj-y not in lib-y

[PATCH] iomap: iomap should be in obj-y not in lib-y

[Tejun Heo]

devres change moved iomap.o from obj-$(CONFIG_GENERIC_IOMAP) to lib-y
making it not linked if no in-kernel driver uses it.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>

diff --git a/lib/Makefile b/lib/Makefile
index 29b2e99..3b605da 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -5,14 +5,14 @@
 lib-y := ctype.o string.o vsprintf.o cmdline.o \
 	 bust_spinlocks.o rbtree.o radix-tree.o dump_stack.o \
 	 idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \
-	 sha1.o irq_regs.o reciprocal_div.o iomap.o
+	 sha1.o irq_regs.o reciprocal_div.o
 
 lib-$(CONFIG_MMU) += ioremap.o
 lib-$(CONFIG_SMP) += cpumask.o
 
 lib-y	+= kobject.o kref.o kobject_uevent.o klist.o
 
-obj-y += sort.o parser.o halfmd4.o debug_locks.o random32.o
+obj-y += sort.o parser.o halfmd4.o debug_locks.o random32.o iomap.o
 
 ifeq ($(CONFIG_DEBUG_KOBJECT),y)
 CFLAGS_kobject.o += -DDEBUG

Re: [PATCH] iomap: iomap should be in obj-y not in lib-y

[Jeff Garzik]

Tejun Heo wrote:
> devres change moved iomap.o from obj-$(CONFIG_GENERIC_IOMAP) to lib-y
> making it not linked if no in-kernel driver uses it.  Fix it.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied

BTW can you update your scripts to email jeff@garzik.org ?  That's the 
primary email address I signoff with, etc.

jgarzik@pobox.com will continue to work for all eternity, but it makes 
Mozilla Thunderbird stupidly add an unneeded CC.

	Jeff

Re: [PATCH] iomap: iomap should be in obj-y not in lib-y

[Tejun Heo]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> devres change moved iomap.o from obj-$(CONFIG_GENERIC_IOMAP) to lib-y
>> making it not linked if no in-kernel driver uses it.  Fix it.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> applied
> 
> BTW can you update your scripts to email jeff@garzik.org ?  That's the
> primary email address I signoff with, etc.

Okay, done.

> jgarzik@pobox.com will continue to work for all eternity, but it makes
> Mozilla Thunderbird stupidly add an unneeded CC.

Also, you can avoid that by configuring aliases to the thunderbird
account.  It's in account setting -> Manage Identities.  Thungerbird is
pretty neat.  :-)

-- 
tejun

Re: [PATCH] iomap: iomap should be in obj-y not in lib-y

[Jeff Garzik]

Tejun Heo wrote:
> Also, you can avoid that by configuring aliases to the thunderbird
> account.  It's in account setting -> Manage Identities.  Thungerbird is
> pretty neat.  :-)

Already done that, it doesn't seem to work :/

If you ever see JGarzik@DunveganMedia.com in a From line, that's 
Thunderbird screwing up and I didn't catch it.

	Jeff