From: Robert Hancock <hancockr@shaw.ca>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
htejun@gmail.com
Subject: Re: [PATCH RFC] sd: spin down disks on removal or power-down
Date: Wed, 31 Jan 2007 17:45:41 -0600 [thread overview]
Message-ID: <45C12A25.8080805@shaw.ca> (raw)
In-Reply-To: <45C0FA3B.5030508@s5r6.in-berlin.de>
Stefan Richter wrote:
> Robert Hancock wrote:
>>> http://marc.theaimsgroup.com/?t=116922621200002
>> It looks like Tejun's patch essentially does the same thing as mine with
>> the addition of the control from userspace. There is one exception
>> though, my patch also does the stop on removal of the SCSI disk (i.e.
>> writing 1 to its "delete" file in sysfs, what scsiadd -r does).
>
> Isn't sd_shutdown called at this occasion?
Ah, indeed it is. I was thinking of the way I had written my patch,
where it only does the spindown if the system state is SYSTEM_POWER_OFF
so I needed an extra call to force this on removal. Tejun's patch just
checks for not SYSTEM_RESTART, so it should happen on removal as well.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
prev parent reply other threads:[~2007-01-31 23:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 1:47 [PATCH RFC] sd: spin down disks on removal or power-down Robert Hancock
2007-01-29 23:47 ` Andrew Morton
2007-01-29 23:55 ` Robert Hancock
2007-01-30 0:16 ` James Bottomley
2007-01-30 0:33 ` Robert Hancock
2007-01-31 20:21 ` Stefan Richter
2007-01-31 23:45 ` Robert Hancock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C12A25.8080805@shaw.ca \
--to=hancockr@shaw.ca \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).