From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Jeff Garzik <jeff@garzik.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] RESEND: SCSI, libata: add support for ATA_16 commands to libata ATAPI devices
Date: Wed, 31 Jan 2007 19:42:39 -0500 [thread overview]
Message-ID: <45C1377F.6070001@rtr.ca> (raw)
In-Reply-To: <45C1356B.6000907@gmail.com>
Tejun Heo wrote:
> Mark Lord wrote:
>..
>> So, to achieve ATA passthru capability for libata ATAPI,
>> we have to instead use the ATA_16 opcode: a 16-byte command.
>>
>> SCSI normally disallows issuing 16-byte commands to 12-byte devices,
>> so special support has to be added for this.
> I might have missed the discussion but can't we just set
> host->max_cmd_len to 16 unconditionally?
Sure thing, if you and Jeff are happy with that, then lets do it.
I just kind of assumed that the complexity in ata_set_port_max_cmd_len()
was there for some kind of reason.
For example, I think all existing ATAPI drives only speak 12-byte packet
protocols, and so if we tell SCSI we're good for 16-byte, then won't the
SCSI layer suddenly start sending us READ_16 and the like?
Cheers
next prev parent reply other threads:[~2007-02-01 0:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 0:35 [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices Mark Lord
2007-01-03 1:40 ` James Bottomley
2007-01-03 5:42 ` Mark Lord
2007-01-03 15:31 ` James Bottomley
2007-01-03 15:45 ` Jeff Garzik
2007-01-03 15:57 ` James Bottomley
2007-01-03 17:58 ` Mark Lord
2007-01-03 19:39 ` Douglas Gilbert
2007-01-03 21:41 ` James Bottomley
2007-01-03 23:57 ` Mark Lord
2007-01-04 15:09 ` Jens Axboe
2007-01-04 15:29 ` Mark Lord
2007-01-04 15:51 ` Jens Axboe
2007-01-08 5:00 ` Luben Tuikov
[not found] ` <200701311346.26644.liml@rtr.ca>
2007-02-01 0:33 ` [PATCH] RESEND: " Tejun Heo
2007-02-01 0:42 ` Mark Lord [this message]
2007-02-01 0:48 ` James Bottomley
2007-02-01 0:53 ` Mark Lord
2007-02-01 0:48 ` Tejun Heo
2007-02-01 1:01 ` Mark Lord
2007-02-01 8:30 ` Jeff Garzik
2007-02-01 8:28 ` Jeff Garzik
2007-02-01 8:43 ` Tejun Heo
2007-02-01 9:54 ` Jeff Garzik
2007-02-01 15:09 ` James Bottomley
2007-02-01 15:15 ` Jeff Garzik
2007-02-01 20:21 ` Douglas Gilbert
2007-02-01 20:30 ` Jeff Garzik
2007-02-02 9:11 ` Christoph Hellwig
2007-02-01 8:26 ` Jeff Garzik
2007-02-01 8:35 ` Tejun Heo
2007-02-01 9:52 ` Jeff Garzik
2007-02-01 0:44 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C1377F.6070001@rtr.ca \
--to=liml@rtr.ca \
--cc=James.Bottomley@hansenpartnership.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).