From: Tejun Heo <htejun@gmail.com>
To: Simon Farnsworth <simon@farnz.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: VIA AHCI NCQ [was: Re: Recent AHCI drivers do not work with VIA VT8251 controllers (regression in 2.6.19 from 2.6.18)]
Date: Thu, 01 Feb 2007 10:20:59 +0900 [thread overview]
Message-ID: <45C1407B.1000703@gmail.com> (raw)
In-Reply-To: <200701312034.36499.simon@farnz.org.uk>
Simon Farnsworth wrote:
> On Tuesday 30 January 2007 15:53, Simon Farnsworth wrote:
>> Hello,
>>
>> I've got a VIA VT8251 AHCI controller, driving two Maxtor SATA disks.
>> Under Linux 2.6.18.5, it works; using 2.6.19.1, it fails to work (bug
>> report at http://bugzilla.kernel.org/show_bug.cgi?id=7589 - note that
>> pci=nomsi does not fix things for me, as I still get no interrupts).
>>
> I've been going through 2.6.20-rc releases this evening. 2.6.20-rc7 resolves
> my AHCI fault (although not the MSI problem); it looks like Tejun Heo's fix
> to ahci_thaw() in a718728f9e40ec79c0879ec6509a54fee214f5b2 fixes things for
> my setup.
Yeah, that was my mistake spotted by Jeff. IRQ pending was never
cleared properly so the controller couldn't raise it.
> Of course, I'm now curious as to why NCQ is disabled on VIA AHCI controllers.
> Is there a known hardware bug I should be wary of, or is it just a case of
> being cautious due to the other issues with the VT8251 (in which case I'll
> try enabling it and reporting back)?
Yeap, there is a known NCQ problem with vt8251. Can't find the original
bug report now tho.
commit 71f0737b2889b86f774a94afaf1342c2c0d61cb5
tree e983d3f4c3fccad0679aa8ae18a0c3ce91bfafe7
parent 8fa29b23d9e0ef976dc578aab98297d4f24f70da
author Tejun Heo <htejun@gmail.com> 1150899168 +0900
committer Jeff Garzik <jeff@garzik.org> 1151032959 -0400
[PATCH] ahci: disable NCQ support on vt8251
vt8251 chokes on NCQ commands. Two different disks from different
vendors are showing the same symptom and it seems that the windows
driver from via doesn't support NCQ either. Disable NCQ support on
this controller for the time being.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Aalderd Bouwman <boac@wanadoo.nl>
Cc: Bastiaan Jacques <b.jacques@planet.nl>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
--
tejun
prev parent reply other threads:[~2007-02-01 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 15:53 Recent AHCI drivers do not work with VIA VT8251 controllers (regression in 2.6.19 from 2.6.18) Simon Farnsworth
2007-01-31 20:34 ` VIA AHCI NCQ [was: Re: Recent AHCI drivers do not work with VIA VT8251 controllers (regression in 2.6.19 from 2.6.18)] Simon Farnsworth
2007-02-01 1:20 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C1407B.1000703@gmail.com \
--to=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=simon@farnz.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).