From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
justin@jmicron.com
Subject: Re: [PATCH libata-dev#upstream-fixes] ahci/pata_jmicron: fix JMicron quirk
Date: Fri, 02 Feb 2007 11:54:57 -0500 [thread overview]
Message-ID: <45C36CE1.9040909@garzik.org> (raw)
In-Reply-To: <20070202055109.GM8606@htj.dyndns.org>
Tejun Heo wrote:
> For all JMicrons except for 361 and 368, AHCI mode enable bits in the
> Control(1) should be set. This used to be done in both ahci and
> pata_jmicron but while moving programming to PCI quirk, it was removed
> from ahci part while still left in pata_jmicron.
>
> The implemented JMicron PCI quirk was incorrect in that it didn't
> program AHCI mode enable bits. If pata_jmicron is loaded first and
> programs those bits, the ahci ports work; otherwise, ahci device
> detection fails miserably.
>
> This patch makes JMicron PCI quirk clear SATA IDE mode bits and set
> AHCI mode bits and remove the respective part from pata_jmicron.
> Tested on JMB361, 363 and 368.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied
prev parent reply other threads:[~2007-02-02 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 5:51 [PATCH libata-dev#upstream-fixes] ahci/pata_jmicron: fix JMicron quirk Tejun Heo
2007-02-02 10:03 ` Alan
2007-02-02 16:54 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C36CE1.9040909@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=justin@jmicron.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).