From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide-floppy: Fix unformatted media crash
Date: Fri, 02 Feb 2007 23:05:20 +0100 [thread overview]
Message-ID: <45C3B5A0.7010503@gmail.com> (raw)
In-Reply-To: <58cb370e0702021351j57c3b559v53741f09acab0b8b@mail.gmail.com>
Alan wrote:
>
> A ZIP or similar with unformatted media will cause crashes when attempts
> are made to read/write it in some cases. This is because bs_factor is
> zero and we divide by it causing an oops.
>
> As the size of a non-accessible/non-existant media is really a bit of a
> zen question it doesn't matter if non-existant media is 512 bytes per
> sector or zero. Setting it to 1 causes us to generate 512 bytes/sector
> accesses and error properly.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
applied, thanks
> Based on a fix found lurking in an ancient bugzilla entry since about
> 2004 (ugghhh)
prev parent reply other threads:[~2007-02-02 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 17:41 [PATCH] ide-floppy: Fix unformatted media crash Alan
[not found] ` <58cb370e0702021351j57c3b559v53741f09acab0b8b@mail.gmail.com>
2007-02-02 22:05 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C3B5A0.7010503@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).