[PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

[PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

[Sergei Shtylyov]

Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
fast timing bank starting with PIO2, just like the ata_piix driver does.
Also, fix/rephrase some comments while at it.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
 drivers/ata/pata_oldpiix.c |   18 ++++++++++--------
 1 files changed, 10 insertions(+), 8 deletions(-)

Index: linux-2.6/drivers/ata/pata_oldpiix.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_oldpiix.c
+++ linux-2.6/drivers/ata/pata_oldpiix.c
@@ -25,7 +25,7 @@
 #include <linux/ata.h>
 
 #define DRV_NAME	"pata_oldpiix"
-#define DRV_VERSION	"0.5.2"
+#define DRV_VERSION	"0.5.3"
 
 /**
  *	oldpiix_pre_reset		-	probe begin
@@ -94,19 +94,21 @@ static void oldpiix_set_piomode (struct 
 			    { 2, 1 },
 			    { 2, 3 }, };
 
-	if (pio > 2)
-		control |= 1;	/* TIME1 enable */
+	if (pio > 1)
+		control |= 1;	/* TIME */
 	if (ata_pio_need_iordy(adev))
-		control |= 2;	/* IE IORDY */
+		control |= 2;	/* IE */
 
-	/* Intel specifies that the PPE functionality is for disk only */
+	/* Intel specifies that the prefetch/posting is for disk only */
 	if (adev->class == ATA_DEV_ATA)
-		control |= 4;	/* PPE enable */
+		control |= 4;	/* PPE */
 
 	pci_read_config_word(dev, idetm_port, &idetm_data);
 
-	/* Enable PPE, IE and TIME as appropriate. Clear the other
-	   drive timing bits */
+	/*
+	 * Set PPE, IE and TIME as appropriate.
+	 * Clear the other drive's timing bits.
+	 */
 	if (adev->devno == 0) {
 		idetm_data &= 0xCCE0;
 		idetm_data |= control;

Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

[Jeff Garzik]

Sergei Shtylyov wrote:
> Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> fast timing bank starting with PIO2, just like the ata_piix driver does.
> Also, fix/rephrase some comments while at it.
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> ---
>  drivers/ata/pata_oldpiix.c |   18 ++++++++++--------
>  1 files changed, 10 insertions(+), 8 deletions(-)

applied

Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

[Sergei Shtylyov]

Hello, I wrote:

> Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> fast timing bank starting with PIO2, just like the ata_piix driver does.
> Also, fix/rephrase some comments while at it.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

   Hm, looks like pata_efar still needs the same fix...

MBR, Sergei

Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

[Alan Cox]

On Sun, 31 May 2009 17:25:14 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:

> Hello, I wrote:
> 
> > Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> > fast timing bank starting with PIO2, just like the ata_piix driver does.
> > Also, fix/rephrase some comments while at it.
> >
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
>    Hm, looks like pata_efar still needs the same fix...

I can't find the original email (not in my archive for 2008 or 2009) but
the comment makes sense

Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

[Sergei Shtylyov]

Alan Cox wrote:

>>Hello, I wrote:

>>>Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
>>>fast timing bank starting with PIO2, just like the ata_piix driver does.
>>>Also, fix/rephrase some comments while at it.

>>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

>>   Hm, looks like pata_efar still needs the same fix...

> I can't find the original email (not in my archive for 2008 or 2009) but
> the comment makes sense

    It was the patch merged back in 2007. I'll submit the pata_efar patch 
shortly.

MBR, Sergei