Re: [PATCH] sata_promise: fix missing PATA cable detection

[Jeff Garzik <jeff@garzik.org>]

Mikael Pettersson wrote:
> This patch fixes an oversight which caused sata_promise to
> not perform cable detection on the TX2plus chips' PATA ports.
> 
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> 
> ---
> 
> This patch adds yet another is-PATA-or-SATA? check, but it's in a
> cold path so shouldn't matter much. This will be cleaned up if/when
> PATA ports and SATA ports start using different ops structures.
> 
> --- linux-2.6.20/drivers/ata/sata_promise.c.~1~	2007-02-07 20:30:20.000000000 +0100
> +++ linux-2.6.20/drivers/ata/sata_promise.c	2007-02-07 20:57:34.000000000 +0100
> @@ -601,6 +601,13 @@ static void pdc_thaw(struct ata_port *ap
>  	readl(mmio + PDC_CTLSTAT); /* flush */
>  }
>  
> +static int pdc_pre_reset(struct ata_port *ap)
> +{
> +	if (!sata_scr_valid(ap))
> +		pdc_pata_cbl_detect(ap);
> +	return ata_std_prereset(ap);
> +}
> +

Since it was a bug in the original patch, I just dropped it, waiting for 
you to resend the whole thing.  That keeps the git history much more clean.

I agree with your comment above -- SATA and PATA ports should use 
different ops structures

	Jeff