Re: sata_vsc with iq3124h regression in 2.6.20

[Tejun Heo <htejun@gmail.com>]

Dan Williams wrote:
> The error interrupt handling code is still in there and is working.  The
> following patch works for me.
> 
> ---
> sata_vsc: handle unexpected interrupts when executing a polled IDENTIFY
> 
> From: Dan Williams <dan.j.williams@intel.com>
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> 
>  drivers/ata/sata_vsc.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ata/sata_vsc.c b/drivers/ata/sata_vsc.c
> index 0fa1b89..7425d62 100644
> --- a/drivers/ata/sata_vsc.c
> +++ b/drivers/ata/sata_vsc.c
> @@ -258,7 +258,9 @@ static irqreturn_t vsc_sata_interrupt (int irq, void *dev_instance)
>  					/* Clear interrupt status */
>  					ata_chk_status(ap);
>  					handled++;
> -				}
> +				} else if (qc->tf.command == ATA_CMD_ID_ATA)
> +					/* 31244 interrupts on polled IDENTIFY commands */
> +					ata_chk_status(ap);
>  			}
>  		}
>  	}

I see.  Can you please...

1. move per-port interrupt handling code (everything inside the for 
loop) to a separate function

2. make the if/else control block look like the following?

   if (unlikely(no irq))
	return 0;
   if (intr command in progress)
	return ata_host_intr()
   if (error_intr())
	error intr handling sans irq clearing.

   clear IRQ
   return 1;

3. Post the patch (probably two patches, one to separate out 
vsc_port_intr() and another to fix the problem) with proper subject lines.

Thanks.

-- 
tejun