From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3
Date: Thu, 15 Feb 2007 18:08:49 -0500 [thread overview]
Message-ID: <45D4E801.8090103@garzik.org> (raw)
In-Reply-To: <20070205142119.GM1625@htj.dyndns.org>
Tejun Heo wrote:
> The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is
> implemented. This increases the chance of incorrect wire detection
> especially because host side cable detection is often unreliable and
> we sometimes soley depend on drive side cable detection. Fix the test
> and add word93 validity check.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Sure, updated as suggested.
>
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 1df9416..939be94 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -347,7 +347,7 @@ static inline int ata_drive_40wire(const u16 *dev_id)
> {
> if (ata_id_major_version(dev_id) >= 5 && ata_id_is_sata(dev_id))
> return 0; /* SATA */
> - if (dev_id[93] & 0x4000)
> + if ((dev_id[93] & 0xE000) == 0x6000)
> return 0; /* 80 wire */
applied
next prev parent reply other threads:[~2007-02-15 23:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 7:45 [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check Tejun Heo
2007-02-05 10:57 ` Alan
2007-02-05 12:41 ` [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 2 Tejun Heo
2007-02-05 13:27 ` Alan
2007-02-05 14:21 ` [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3 Tejun Heo
2007-02-05 14:36 ` Alan
2007-02-15 23:08 ` Jeff Garzik [this message]
2007-07-12 18:40 ` Sergei Shtylyov
2007-07-12 18:50 ` Sergei Shtylyov
2007-07-13 4:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D4E801.8090103@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).