From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [git patches] libata updates (mostly fixes) Date: Thu, 15 Feb 2007 21:09:12 -0500 Message-ID: <45D51248.5070408@garzik.org> References: <20070215233411.GA10782@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:33491 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932491AbXBPCJO (ORCPT ); Thu, 15 Feb 2007 21:09:14 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Linus Torvalds Cc: Andrew Morton , linux-ide@vger.kernel.org, LKML , Alan Cox , "Luck, Tony" , Zhang Yanmin Linus Torvalds wrote: > > On Thu, 15 Feb 2007, Jeff Garzik wrote: >> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig >> index db185f3..d51f0f1 100644 >> --- a/arch/ia64/Kconfig >> +++ b/arch/ia64/Kconfig >> @@ -22,6 +22,7 @@ config IA64 >> >> config 64BIT >> bool >> + select ATA_NONSTANDARD if ATA >> default y > > Ok, this is just _strange_. Agreed. > Tying ATA_NONSTANDARD into ia64 by tying it to the 64BIT config variable > may work (well, I _assume_ it does), but it's just psychedelic. AFAICT it's an attempt to do an unconditional 'select'. I'm /not/ disputing its psychedilic properties, certainly, just figured that was the way that IA64 arch folks did stuff like this. > How about adding a separate config entry like > > config IA64_ATA > bool > depends on ATA > select ATA_NONSTANDARD > default y > > which kind of makes sense when you squint just the right way.. Either way, that seems sane to me. I'd love to have some IA64 folks to comment though. Jeff