Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Olaf Hering wrote:
> Change the default for the built-in IDE on p610/p615/p630 from
> ide to libata. libata has better error handling and the drive can
> recover when hald does its CD media polling.

> Signed-off-by: Olaf Hering <olaf@aepfle.de>

> ---
>  arch/powerpc/configs/ppc64_defconfig   |    4 ++--
>  arch/powerpc/configs/pseries_defconfig |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> Index: linux-2.6.20/arch/powerpc/configs/ppc64_defconfig
> ===================================================================
> --- linux-2.6.20.orig/arch/powerpc/configs/ppc64_defconfig
> +++ linux-2.6.20/arch/powerpc/configs/ppc64_defconfig
> @@ -500,7 +500,7 @@ CONFIG_BLK_DEV_AMD74XX=y
>  # CONFIG_BLK_DEV_PDC202XX_NEW is not set
>  # CONFIG_BLK_DEV_SVWKS is not set
>  # CONFIG_BLK_DEV_SIIMAGE is not set
> -CONFIG_BLK_DEV_SL82C105=y
> +# CONFIG_BLK_DEV_SL82C105 is not set
>  # CONFIG_BLK_DEV_SLC90E66 is not set
>  # CONFIG_BLK_DEV_TRM290 is not set
>  # CONFIG_BLK_DEV_VIA82CXXX is not set
> @@ -646,7 +646,7 @@ CONFIG_SATA_SVW=y
>  # CONFIG_PATA_SIL680 is not set
>  # CONFIG_PATA_SIS is not set
>  # CONFIG_PATA_VIA is not set
> -# CONFIG_PATA_WINBOND is not set
> +CONFIG_PATA_WINBOND=y
>  
>  #
>  # Multi-device support (RAID and LVM)
> Index: linux-2.6.20/arch/powerpc/configs/pseries_defconfig
> ===================================================================
> --- linux-2.6.20.orig/arch/powerpc/configs/pseries_defconfig
> +++ linux-2.6.20/arch/powerpc/configs/pseries_defconfig
> @@ -483,7 +483,7 @@ CONFIG_BLK_DEV_AMD74XX=y
>  # CONFIG_BLK_DEV_PDC202XX_NEW is not set
>  # CONFIG_BLK_DEV_SVWKS is not set
>  # CONFIG_BLK_DEV_SIIMAGE is not set
> -CONFIG_BLK_DEV_SL82C105=y
> +# CONFIG_BLK_DEV_SL82C105 is not set
>  # CONFIG_BLK_DEV_SLC90E66 is not set
>  # CONFIG_BLK_DEV_TRM290 is not set
>  # CONFIG_BLK_DEV_VIA82CXXX is not set
> @@ -628,7 +628,7 @@ CONFIG_ATA=y
>  # CONFIG_PATA_SIL680 is not set
>  # CONFIG_PATA_SIS is not set
>  # CONFIG_PATA_VIA is not set
> -# CONFIG_PATA_WINBOND is not set
> +CONFIG_PATA_WINBOND=y

    I'm sorry, how those 2 drivers can be equivalent?! The pata_winbond driver 
is for VLB only, sl81c105 was for PCI only -- you certainly want to use 
pata_sl82c105 (indeed better version of sl82c105 driver).

WBR, Sergei