2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

[Rafael J. Wysocki]

Update:

I get the same BUG with 2.6.20-git13 100% of the time during the resume.
The system seems to be fully functional nonetheless.

On Thursday, 15 February 2007 12:23, Rafael J. Wysocki wrote:
> Update:
> 
> On Thursday, 15 February 2007 00:16, Rafael J. Wysocki wrote:
> > Hi,
> > 
> > I've got this in the resume-during-suspend phase of suspend to disk with
> > 2.6.20-git10 on HPC nx6325:
> > 
> > PCI: Setting latency timer of device 0000:00:06.0 to 64
> > sata_sil 0000:00:12.0: resuming
> > BUG: at drivers/pci/pci.c:817 pcim_enable_device()
> > 
> > Call Trace:
> >  [<ffffffff8031c05e>] pcim_enable_device+0x93/0xb3
> >  [<ffffffff8039a74c>] ata_pci_device_do_resume+0x21/0x5e
> >  [<ffffffff803a5f8a>] sil_pci_device_resume+0x1c/0x51
> >  [<ffffffff8031e072>] pci_device_resume+0x22/0x53
> >  [<ffffffff8038bea4>] resume_device+0xca/0x131
> >  [<ffffffff8038bf8c>] dpm_resume+0x81/0xd3
> >  [<ffffffff8038c00e>] device_resume+0x30/0x45
> >  [<ffffffff802a0d8c>] snapshot_ioctl+0x245/0x63e
> >  [<ffffffff8023f7f2>] do_ioctl+0x5e/0x77
> >  [<ffffffff8022dab2>] vfs_ioctl+0x25c/0x279
> >  [<ffffffff8024948a>] sys_ioctl+0x5f/0x82
> >  [<ffffffff8021555d>] sys_write+0x47/0x70
> >  [<ffffffff8025911e>] system_call+0x7e/0x83
> > 
> > The box has survived the entire suspend-resume cycle, though, and seems to be
> > fully functional.
> 
> I get this 100% of the time, but the box suspends and behaves normally after
> the resume.

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

[Tejun Heo]

Rafael J. Wysocki wrote:
> Update:
> 
> I get the same BUG with 2.6.20-git13 100% of the time during the resume.
> The system seems to be fully functional nonetheless.

Known bug, will be fixed soon.

-- 
tejun

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

[Adrian Bunk]

On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
> Rafael J. Wysocki wrote:
> > Update:
> > 
> > I get the same BUG with 2.6.20-git13 100% of the time during the resume.
> > The system seems to be fully functional nonetheless.
> 
> Known bug, will be fixed soon.

Is this a variation of

Subject    : HP nx6325: usb mouse stops working after resume from ram
References : http://lkml.org/lkml/2007/2/21/413
Submitter  : Arkadiusz Miskiewicz <arekm@maven.pl>
Caused-By  : Konstantin Karasyov <konstantin.a.karasyov@intel.com>
             commit 0a6139027f3986162233adc17285151e78b39cac
Status     : unknown

or one of the other ACPI problems in 2.6.21-rc1?

> tejun

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

[Tejun Heo]

Hello, Adrian.

Adrian Bunk wrote:
> On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
>> Rafael J. Wysocki wrote:
>>> Update:
>>>
>>> I get the same BUG with 2.6.20-git13 100% of the time during the resume.
>>> The system seems to be fully functional nonetheless.
>> Known bug, will be fixed soon.
> 
> Is this a variation of
> 
> Subject    : HP nx6325: usb mouse stops working after resume from ram
> References : http://lkml.org/lkml/2007/2/21/413
> Submitter  : Arkadiusz Miskiewicz <arekm@maven.pl>
> Caused-By  : Konstantin Karasyov <konstantin.a.karasyov@intel.com>
>              commit 0a6139027f3986162233adc17285151e78b39cac
> Status     : unknown
> 
> or one of the other ACPI problems in 2.6.21-rc1?

No, it's not related to ACPI.  It's caused by devres changes and fixed
in libata-dev tree.

-- 
tejun

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

[Adrian Bunk]

On Sun, Feb 25, 2007 at 01:28:42PM +0900, Tejun Heo wrote:
> Hello, Adrian.
> 
> Adrian Bunk wrote:
> > On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
> >> Rafael J. Wysocki wrote:
> >>> Update:
> >>>
> >>> I get the same BUG with 2.6.20-git13 100% of the time during the resume.
> >>> The system seems to be fully functional nonetheless.
> >> Known bug, will be fixed soon.
> > 
> > Is this a variation of
> > 
> > Subject    : HP nx6325: usb mouse stops working after resume from ram
> > References : http://lkml.org/lkml/2007/2/21/413
> > Submitter  : Arkadiusz Miskiewicz <arekm@maven.pl>
> > Caused-By  : Konstantin Karasyov <konstantin.a.karasyov@intel.com>
> >              commit 0a6139027f3986162233adc17285151e78b39cac
> > Status     : unknown
> > 
> > or one of the other ACPI problems in 2.6.21-rc1?
> 
> No, it's not related to ACPI.  It's caused by devres changes and fixed
> in libata-dev tree.

I'm currently a bit lost with all the ATA/ACPI/suspend regression 
reports...

Which patch fixes this regression?

> tejun

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

[Tejun Heo]

Adrian Bunk wrote:
> On Sun, Feb 25, 2007 at 01:28:42PM +0900, Tejun Heo wrote:
>> Hello, Adrian.
>>
>> Adrian Bunk wrote:
>>> On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
>>>> Rafael J. Wysocki wrote:
>>>>> Update:
>>>>>
>>>>> I get the same BUG with 2.6.20-git13 100% of the time during the resume.
>>>>> The system seems to be fully functional nonetheless.
>>>> Known bug, will be fixed soon.
>>> Is this a variation of
>>>
>>> Subject    : HP nx6325: usb mouse stops working after resume from ram
>>> References : http://lkml.org/lkml/2007/2/21/413
>>> Submitter  : Arkadiusz Miskiewicz <arekm@maven.pl>
>>> Caused-By  : Konstantin Karasyov <konstantin.a.karasyov@intel.com>
>>>              commit 0a6139027f3986162233adc17285151e78b39cac
>>> Status     : unknown
>>>
>>> or one of the other ACPI problems in 2.6.21-rc1?
>> No, it's not related to ACPI.  It's caused by devres changes and fixed
>> in libata-dev tree.
> 
> I'm currently a bit lost with all the ATA/ACPI/suspend regression 
> reports...
> 
> Which patch fixes this regression?

What I was talking about was the following one.  It's a libata bug
discovered by devres sanity check and unrelated to ACPI.

Author: Tejun Heo <htejun@gmail.com>  2007-02-20 18:14:48
Committer: Jeff Garzik <jeff@garzik.org>  2007-02-21 18:58:18
Parent: 5e5c74a5e11d1e2a99d03132cc6c4455016db6c2 (sata_nv: delay on switching between NCQ and non-NCQ commands)
Child:  6d1245bf294e9ea65b3717be9fa0338bfb6ff6c9 (libata: separate out ata_ncq_enabled())
Branches: upstream-fixes, upstream, ALL
Follows: v2.6.21-rc1
Precedes: 

    libata: disable pdev on all suspend events
    
    libata used disable pdev only on PM_EVENT_SUSPEND while re-enable pdev
    unconditionally.  This was okay before ref-counted pdev enable update
    but it now makes the pdev pinned after swsusp cycle (enabled twice but
    disabled only once) and devres sanity check whines about it.
    
    Fix it by unconditionally disabling pdev on all suspend events.
    
    Signed-off-by: Tejun Heo <htejun@gmail.com>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>

-- 
tejun