From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] libata: fix probe_ent alloc/free bugs
Date: Tue, 20 Feb 2007 17:37:47 +0900 [thread overview]
Message-ID: <45DAB35B.50005@gmail.com> (raw)
In-Reply-To: <45D73A55.90008@gmail.com>
Tejun Heo wrote:
> ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc()
> was used for allocation if devres had been previously initialized on
> the device; otherwise, plain kzalloc() was used. This was to make the
> code useable from both the old and devres-aware libata drivers during
> transition. This hack made ata_sas_port_alloc() unable to determine
> how the probe_ent is allocated, causing double free in some cases.
>
> Remove the now-unneeded hack and make ata_sas_port_alloc() use
> devm_kfree().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: James Bottomley <James.Bottomley@SteelEye.com>
> ---
> James, thanks for the diagnosis and please ack if this fixes the
> problem.
>
> Jeff, after James' ack, can you please verify this works with a libata
> driver? Just loading and unloading a libata LLD should be enough.
> I'm visiting my hometown for lunar new year's day, so I can't do it
> till Tuesday.
Okay, verified. Please apply.
--
tejun
next prev parent reply other threads:[~2007-02-20 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 14:27 [PATCH] libata: fix probe_ent free in ata_sas_port_alloc() Tejun Heo
2007-02-17 15:16 ` James Bottomley
2007-02-17 17:24 ` [PATCH] libata: fix probe_ent alloc/free bugs Tejun Heo
2007-02-17 17:43 ` Sergei Shtylyov
2007-02-17 18:19 ` James Bottomley
2007-02-17 18:27 ` Sergei Shtylyov
2007-02-17 18:09 ` James Bottomley
2007-02-20 8:37 ` Tejun Heo [this message]
2007-02-20 15:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DAB35B.50005@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).