From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg KH <greg@kroah.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
pavel@suse.cz
Subject: Re: [PATCH] libata: disable pdev on all suspend events
Date: Tue, 20 Feb 2007 11:02:41 -0500 [thread overview]
Message-ID: <45DB1BA1.4010802@garzik.org> (raw)
In-Reply-To: <45DABC08.9030607@gmail.com>
Tejun Heo wrote:
> libata used disable pdev only on PM_EVENT_SUSPEND while re-enable pdev
> unconditionally. This was okay before ref-counted pdev enable update
> but it now makes the pdev pinned after swsusp cycle (enabled twice but
> disabled only once) and devres sanity check whines about it.
>
> Fix it by unconditionally disabling pdev on all suspend events.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Pavel, I took your advice and chose to disable unconditionally rather
> than recording the status separately, but I still think it would be
> nice if we can tell the status we're waking from from either the mesg
> itself (say, PM_EVENT_THAW) or recorded prev state.
>
> Both STM and STD are tested. Please apply. Thanks.
applied
prev parent reply other threads:[~2007-02-20 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070216213153.f6704ff5.akpm@linux-foundation.org>
[not found] ` <45D6FE5A.1080603@gmail.com>
2007-02-20 9:14 ` [PATCH] libata: disable pdev on all suspend events Tejun Heo
2007-02-20 16:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DB1BA1.4010802@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).