Re: [PATCH] libata: s/ap->id/ap->print_id/g

[Jeff Garzik <jeff@garzik.org>]

Tejun Heo wrote:
> ata_port has two different id fields - id and port_no.  id is
> system-wide 1-based unique id for the port while port_no is 0-based
> host-wide port number.  The former is primarily used to identify the
> ATA port to the user in printk messages while the latter is used in
> various places in libata core and LLDs to index the port inside the
> host.
> 
> The two fields feel quite similar and sometimes ap->id is used in
> place of ap->port_no, which is very difficult to spot.  This patch
> renames ap->id to ap->print_id to reduce the possibility of such bugs.
> 
> Some printk messages are adjusted such that id string (ata%u[.%u])
> isn't printed twice and/or to use ata_*_printk() instead of hardcoded
> id format.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied