From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver
Date: Thu, 22 Feb 2007 01:57:11 -0500 [thread overview]
Message-ID: <45DD3EC7.3050801@garzik.org> (raw)
In-Reply-To: <45DD2EC9.4050403@shaw.ca>
Robert Hancock wrote:
> This patch adds in some NCQ blacklist entries taken from the Silicon
> Image Windows drivers' .inf files for the 3124 and 3132 controllers.
> These entries were marked as ""DisableSataQueueing". Assume these are
> in their blacklist for a reason and disable NCQ on these drives.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
>
> --- linux-2.6.21-rc1edit/drivers/ata/libata-core.c.prev 2007-02-21
> 22:23:05.000000000 -0600
> +++ linux-2.6.21-rc1edit/drivers/ata/libata-core.c 2007-02-21
> 22:25:44.000000000 -0600
> @@ -3269,6 +3269,13 @@ static const struct ata_blacklist_entry
> /* Devices with NCQ limits */
>
> + /* The following blacklist entries are taken from the Windows
> + driver .inf files for the Silicon Image 3124 and 3132. */
> + { "Maxtor 7B250S0", "BANC1B70", ATA_HORKAGE_NONCQ, },
> + { "HTS541060G9SA00", "MB3OC60D", ATA_HORKAGE_NONCQ, },
> + { "HTS541080G9SA00", "MB4OC60D", ATA_HORKAGE_NONCQ, },
> + { "HTS541010G9SA00", "MBZOC60D", ATA_HORKAGE_NONCQ, },
Do we have information that these drives fail on non-SiI controllers?
Sometimes the problem can be related to a single family of controllers.
Jeff
next prev parent reply other threads:[~2007-02-22 6:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 5:48 [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver Robert Hancock
2007-02-22 6:57 ` Jeff Garzik [this message]
2007-02-22 11:32 ` Jens Axboe
2007-02-22 14:41 ` Mark Lord
2007-02-22 15:41 ` Jens Axboe
2007-02-22 15:04 ` Ask Bjørn Hansen
2007-02-23 0:18 ` Robert Hancock
2007-02-23 0:21 ` Ask Bjørn Hansen
2007-02-23 22:16 ` Jeff Garzik
2007-03-21 7:32 ` Tejun Heo
2007-03-21 12:52 ` Mathieu Bérard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DD3EC7.3050801@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).