From: Tejun Heo <htejun@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, jeremy@sgi.com
Subject: Re: [PATCH 2.6.21-rc1 2/2] sata_vsc: clean up vsc_sata_interrupt
Date: Fri, 23 Feb 2007 13:11:38 +0900 [thread overview]
Message-ID: <45DE697A.50707@gmail.com> (raw)
In-Reply-To: <20070221175652.21231.18391.stgit@dwillia2-linux.ch.intel.com>
Hello,
Just one nit.
Dan Williams wrote:
> + if (unlikely(status == 0xffffffff || status == 0)) {
> + status && printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, "
> + "PCI fault or device removal?\n");
People usually don't like using logical operator short circuit for
branching. Just put another if () and you can also use dev_printk() there.
Other than that, everything looks good. Thanks for doing this.
--
tejun
prev parent reply other threads:[~2007-02-23 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 17:56 [PATCH 2.6.21-rc1 0/2] sata_vsc regression fix and vsc_sata_interrupt_cleanup (take2) Dan Williams
2007-02-21 17:56 ` [PATCH 2.6.21-rc1 1/2] sata_vsc: factor the error and normal intr paths into separate routines Dan Williams
2007-02-23 4:08 ` Tejun Heo
2007-02-23 22:24 ` Jeff Garzik
2007-02-21 17:56 ` [PATCH 2.6.21-rc1 2/2] sata_vsc: clean up vsc_sata_interrupt Dan Williams
2007-02-23 4:11 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DE697A.50707@gmail.com \
--to=htejun@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=jeff@garzik.org \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).