From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>, Dan Williams <dan.j.williams@intel.com>
Cc: linux-ide@vger.kernel.org, jeremy@sgi.com
Subject: Re: [PATCH 2.6.21-rc1 1/2] sata_vsc: factor the error and normal intr paths into separate routines
Date: Fri, 23 Feb 2007 17:24:06 -0500 [thread overview]
Message-ID: <45DF6986.9040408@garzik.org> (raw)
In-Reply-To: <45DE68D2.4010306@gmail.com>
Tejun Heo wrote:
> Sorry to keep nagging about patch separation and your way could be okay
> too, but IMHO this can be done better in one of the following ways.
>
> 1. Keep two patches. One to break down the interrupt handler the other
> to improve it. In this case the first one shouldn't introduce major new
> features but just focus on breaking down existing one.
>
> 2. Do it in single patch. It seems the changes are localized enough.
> Just name it something like 'reimplement irq handler' and list changes
> in the commit message.
>
> After seeing the change, I'm leaning toward #2. Thanks. :-)
These two sata_vsc changes should be done in a single patch. "add new
stuff" and "use new stuff" patches can be combined. The types of
patches that normally should be separated are logical changes like
"clean up irq handling" or "improve EH", changes that can be
git-bisect'd usefully.
The changes look OK to me.
Jeff
next prev parent reply other threads:[~2007-02-23 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 17:56 [PATCH 2.6.21-rc1 0/2] sata_vsc regression fix and vsc_sata_interrupt_cleanup (take2) Dan Williams
2007-02-21 17:56 ` [PATCH 2.6.21-rc1 1/2] sata_vsc: factor the error and normal intr paths into separate routines Dan Williams
2007-02-23 4:08 ` Tejun Heo
2007-02-23 22:24 ` Jeff Garzik [this message]
2007-02-21 17:56 ` [PATCH 2.6.21-rc1 2/2] sata_vsc: clean up vsc_sata_interrupt Dan Williams
2007-02-23 4:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DF6986.9040408@garzik.org \
--to=jeff@garzik.org \
--cc=dan.j.williams@intel.com \
--cc=htejun@gmail.com \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).