From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_mv: fix pci_enable_msi() error handling
Date: Sat, 24 Feb 2007 20:52:29 -0500 [thread overview]
Message-ID: <45E0EBDD.20106@garzik.org> (raw)
In-Reply-To: <20070224061231.GZ1625@htj.dyndns.org>
Tejun Heo wrote:
> intx should be turned on when pci_enable_msi() fails not when it
> succeeds. Fix it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 06867b9..d724bc7 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -2347,7 +2347,7 @@ static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> return rc;
>
> /* Enable interrupts */
> - if (msi && !pci_enable_msi(pdev))
> + if (msi && pci_enable_msi(pdev))
> pci_intx(pdev, 1);
applied
prev parent reply other threads:[~2007-02-25 1:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 6:12 [PATCH] sata_mv: fix pci_enable_msi() error handling Tejun Heo
2007-02-25 1:52 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E0EBDD.20106@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).