* Re: sata_nv: cleanup CPB and APRD initialization
[not found] <200702262259.l1QMxKug009433@hera.kernel.org>
@ 2007-02-26 23:26 ` Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2007-02-26 23:26 UTC (permalink / raw)
To: hancockr; +Cc: IDE/ATA development list
Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=41949ed5c11a9d6e7af1afd62957d8d1988c803e
> Commit: 41949ed5c11a9d6e7af1afd62957d8d1988c803e
> Parent: 08af7414786a3f35b686f68ada3de0b202c03d8c
> Author: Robert Hancock <hancockr@shaw.ca>
> AuthorDate: Mon Feb 19 19:02:27 2007 -0600
> Committer: Jeff Garzik <jeff@garzik.org>
> CommitDate: Wed Feb 21 04:58:19 2007 -0500
>
> sata_nv: cleanup CPB and APRD initialization
>
> Clean up the initialization of the CPB and APRD structures so that we
> strictly follow the rules for ordering of writes to the CPB flags and
> response flags, and prevent duplicate initialization.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
> ---
> @@ -1199,6 +1196,8 @@ static void nv_adma_fill_sg(struct ata_queued_cmd *qc, struct nv_adma_cpb *cpb)
> }
> if (idx > 5)
> cpb->next_aprd = cpu_to_le64(((u64)(pp->aprd_dma + NV_ADMA_SGTBL_SZ * qc->tag)));
> + else
> + cpb->next_aprd = cpu_to_le64(0);
Note, there is no need to convert a zero to little endian. There are no
bits to swap :)
Jeff
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-02-26 23:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200702262259.l1QMxKug009433@hera.kernel.org>
2007-02-26 23:26 ` sata_nv: cleanup CPB and APRD initialization Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).