From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] libata: add missing CONFIG_PM in LLDs
Date: Fri, 02 Mar 2007 21:02:46 +0900 [thread overview]
Message-ID: <45E81266.3060108@gmail.com> (raw)
In-Reply-To: <20070302125732.2eb9e67e@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> Ughhhhhhhhh...
>
> Can we not just provide dummy methods ?
I agree that it's ugly but LDDs often wrap standard routines and with
the third patch all standard routines are gone thus forcing LLDs to omit
PM functions if !CONFIG_PM. If we supply dummy core functions, forcing
LLDs to skip private PM functions is difficult.
ata_scsi_device_suspend/resume() will disappear soon, so the clutter
will be reduced. Any prettier ideas?
--
tejun
next prev parent reply other threads:[~2007-03-02 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 8:30 [PATCH 1/3] libata: add missing PM callbacks Tejun Heo
2007-03-02 8:31 ` [PATCH 2/3] libata: add missing CONFIG_PM in LLDs Tejun Heo
2007-03-02 8:32 ` [PATCH 3/3] libata: add CONFIG_PM to libata core layer Tejun Heo
2007-03-02 12:57 ` [PATCH 2/3] libata: add missing CONFIG_PM in LLDs Alan Cox
2007-03-02 12:02 ` Tejun Heo [this message]
2007-03-02 13:19 ` Alan Cox
2007-03-02 12:22 ` Tejun Heo
2007-03-02 12:56 ` [PATCH 1/3] libata: add missing PM callbacks Alan Cox
2007-03-02 23:31 ` Jeff Garzik
2007-03-03 3:11 ` Tejun Heo
2007-03-06 8:05 ` Pavel Machek
2007-03-06 8:13 ` Tejun Heo
2007-03-06 8:22 ` Pavel Machek
2007-03-06 10:20 ` Andrew Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E81266.3060108@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).