From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata: Cable detection fixes Date: Fri, 02 Mar 2007 17:50:03 -0500 Message-ID: <45E8AA1B.6000803@garzik.org> References: <20070301173003.5d5ab4a6@lxorguk.ukuu.org.uk> <45E77D60.0@garzik.org> <20070302124534.5fcfec9f@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:54362 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992702AbXCBWuE (ORCPT ); Fri, 2 Mar 2007 17:50:04 -0500 In-Reply-To: <20070302124534.5fcfec9f@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , torvalds@osdl.org Alan Cox wrote: >> However, given that we are in -rc cycle, and the wide impact of this >> change, this patch wants splitting. The ->cable_detect stuff should be >> in a separate patch from the IDENTIFY DEVICE ordering stuff. This >> ensures sanity when git-bisecting changes, and allows fast-tracking of >> the identify-ordering change. > > Fine by me - I carefully sent Linus the hook but no changes using it and > sent those changes just to the list/you. The implication was that you should revise, sign-off, and resend, like all the other kernel developers do when they receive feedback during engineering review... Nonetheless, I extracted and applied the patch I mention above, and will send it upstream today. Jeff