From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_legacy: Fix missing methods and add cable types
Date: Fri, 02 Mar 2007 18:12:26 -0500 [thread overview]
Message-ID: <45E8AF5A.30902@garzik.org> (raw)
In-Reply-To: <20070301174852.6bd60580@lxorguk.ukuu.org.uk>
Alan wrote:
> Several method sets lacked freeze/resume methods. Fix this and while we
> are at it force the cable to 40wire
>
> Signed-off-by: Alan Cox <alan@redhat.com>
For this, pata_sc1200 and pata_sl82c105: applied the missing-hook
portion of the patch, and dropped the ->cable_detect portion pending resend.
Please resend the cable_detect patches one this other stuff lands (will
push tonight). I would suggest doing two patches:
1) add ->cable_detect hook
2) use ->cable_detect in PATA drivers
There is no need to split up the same change across multiple drivers.
It is the same logical change, and people doing git-bisect won't be left
with a broken configuration, so a single update-drivers patch makes more
sense. And, hopefully, is less work for you.
Jeff
prev parent reply other threads:[~2007-03-02 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 17:48 [PATCH] pata_legacy: Fix missing methods and add cable types Alan
2007-03-02 23:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E8AF5A.30902@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).