Re: [PATCH, RFT, v2] sata_mv: convert to new EH

[Jeff Garzik <jeff@garzik.org>]

Dave Dillow wrote:
> On Sun, 2007-02-25 at 18:34 -0500, Jeff Garzik wrote:
>> Just got sata_mv working under the new EH, on my 6041.
>>
>> It probes and talks to disks just fine (chip doesn't support ATAPI),
>> and hotplug actually has a chance of working.
>>
>> The 'mv-eh' branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git mv-eh
> 
> Testing on my Adaptec 1420SA (604x, not sure which) gave several BUG()s,
> and seemed to mount the drive. I immediately unmounted it, as I got
> spooked by the bug reports in dmesg, and I fat fingered ro as rw :(
> 
> sata_mv, and libata built as modules, full .config available on request 

> BUG: at drivers/ata/sata_mv.c:1245 mv_qc_issue()
> BUG: at drivers/ata/sata_mv.c:1245 mv_qc_issue()
> BUG: at drivers/ata/sata_mv.c:1245 mv_qc_issue()
> BUG: at drivers/ata/sata_mv.c:1245 mv_qc_issue()
> BUG: at drivers/ata/sata_mv.c:1291 mv_get_crpb_status()


Thanks much for the testing.  This looks quite similar to the BUG()s 
that someone emailed me in private (so far the only other tester besides 
me and you).

I'll give this a think, and see what I come up with.


> I'd love to get this controller running, as I could use the space. I'll
> test just about anything you want, but my turnaround is likely to be on
> the order of 24 hours or so...

Does the stock upstream driver work for you?  It should already be 
running, just with prehistoric error handling :)

	Jeff