Re: [patch 07/30] libata: add NCQ blacklist entries from Silicon Image Windows driver

[Jeff Garzik <jeff@garzik.org>]

akpm@linux-foundation.org wrote:
> From: Robert Hancock <hancockr@shaw.ca>
> 
> This patch adds in some NCQ blacklist entries taken from the Silicon Image
> Windows drivers' .inf files for the 3124 and 3132 controllers.  These
> entries were marked as ""DisableSataQueueing".  Assume these are in their
> blacklist for a reason and disable NCQ on these drives.
> 
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/ata/libata-core.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff -puN drivers/ata/libata-core.c~libata-add-ncq-blacklist-entries-from-silicon-image-windows drivers/ata/libata-core.c
> --- a/drivers/ata/libata-core.c~libata-add-ncq-blacklist-entries-from-silicon-image-windows
> +++ a/drivers/ata/libata-core.c
> @@ -3368,6 +3368,13 @@ static const struct ata_blacklist_entry 
>  
>  	/* Devices with NCQ limits */
>  
> +	/* The following blacklist entries are taken from the Windows
> +	   driver .inf files for the Silicon Image 3124 and 3132. */
> +	{ "Maxtor 7B250S0",	"BANC1B70",	ATA_HORKAGE_NONCQ, },
> +	{ "HTS541060G9SA00",	"MB3OC60D",	ATA_HORKAGE_NONCQ, },
> +	{ "HTS541080G9SA00",	"MB4OC60D",	ATA_HORKAGE_NONCQ, },
> +	{ "HTS541010G9SA00",	"MBZOC60D",	ATA_HORKAGE_NONCQ, },

Already discussed:  drop the HTS* entries, leaving only the Maxtor, and 
I'll apply it