From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_hpt3x2n: Cable detect handling
Date: Wed, 07 Mar 2007 18:19:26 +0300 [thread overview]
Message-ID: <45EED7FE.9020305@ru.mvista.com> (raw)
In-Reply-To: <20070307161723.49b4b4aa@lxorguk.ukuu.org.uk>
Hello.
Alan Cox wrote:
> +/**
> + * hpt3x2n_pre_reset - reset the hpt3x2n bus
> + * @ap: ATA port to reset
> + *
> + * Perform the initial reset handling for the 3x2n series controllers.
> + * Reset the hardware and state machine,
> + */
>
> +static int hpt3xn_pre_reset(struct ata_port *ap)
> +{
> + struct pci_dev *pdev = to_pci_dev(ap->host->dev);
> /* Reset the state machine */
> pci_write_config_byte(pdev, 0x50, 0x37);
> pci_write_config_byte(pdev, 0x54, 0x37);
> udelay(100);
> -
> return ata_std_prereset(ap);
> }
>
Hmmm... is it really safe to reset both channels here, when only one port
gets reset?
MBR, Sergei
next prev parent reply other threads:[~2007-03-07 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 16:17 [PATCH] pata_hpt3x2n: Cable detect handling Alan Cox
2007-03-07 15:19 ` Sergei Shtylyov [this message]
2007-03-07 17:02 ` Alan Cox
2007-03-09 12:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EED7FE.9020305@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).