From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Petr Vandrovec <petr@vandrovec.name>,
jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fix simplex adapters with libata
Date: Thu, 08 Mar 2007 09:49:33 -0500 [thread overview]
Message-ID: <45F0227D.5010905@rtr.ca> (raw)
In-Reply-To: <20070308130250.5647ce5c@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>
>> diff -uprdN linux/drivers/ata/libata-core.c linux/drivers/ata/libata-core.c
>> --- linux/drivers/ata/libata-core.c 2007-03-07 22:13:24.000000000 -0800
>> +++ linux/drivers/ata/libata-core.c 2007-03-08 00:15:37.000000000 -0800
>> @@ -3455,7 +3455,8 @@ static void ata_dev_xfermask(struct ata_
>> "device is on DMA blacklist, disabling DMA\n");
>> }
>>
>> - if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed != ap) {
>> + if ((host->flags & ATA_HOST_SIMPLEX) &&
>> + host->simplex_claimed && host->simplex_claimed != ap) {
A different version of this fix just went upstream for 2.6.21 via Jeff.
Which of the two is correct?
I believe the other one looks like this:
>> - if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed != ap) {
>> - if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed == ap) {
Cheers
next prev parent reply other threads:[~2007-03-08 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 9:12 [PATCH] Fix simplex adapters with libata Petr Vandrovec
2007-03-08 13:02 ` Alan Cox
2007-03-08 14:49 ` Mark Lord [this message]
2007-03-08 15:05 ` Mark Lord
2007-03-09 1:47 ` vandrove
2007-03-09 12:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F0227D.5010905@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=petr@vandrovec.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).