From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_ns87410: cable detect method
Date: Fri, 09 Mar 2007 07:25:49 -0500 [thread overview]
Message-ID: <45F1524D.40705@pobox.com> (raw)
In-Reply-To: <20070307162207.049af79d@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c linux-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c
> --- linux.vanilla-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c 2007-03-06 23:09:46.000000000 +0000
> +++ linux-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c 2007-03-06 23:36:02.000000000 +0000
> @@ -28,13 +28,13 @@
> #include <linux/libata.h>
>
> #define DRV_NAME "pata_ns87410"
> -#define DRV_VERSION "0.4.3"
> +#define DRV_VERSION "0.4.6"
>
> /**
> * ns87410_pre_reset - probe begin
> * @ap: ATA port
> *
> - * Set up cable type and use generic probe init
> + * Check enabled ports
> */
>
> static int ns87410_pre_reset(struct ata_port *ap)
> @@ -47,7 +47,6 @@
>
> if (!pci_test_config_bits(pdev, &ns87410_enable_bits[ap->port_no]))
> return -ENOENT;
> - ap->cbl = ATA_CBL_PATA40;
> return ata_std_prereset(ap);
> }
>
> @@ -177,6 +176,7 @@
> .thaw = ata_bmdma_thaw,
> .error_handler = ns87410_error_handler,
> .post_internal_cmd = ata_bmdma_post_internal_cmd,
> + .cable_detect = ata_cable_40wire,
>
> .qc_prep = ata_qc_prep,
> .qc_issue = ns87410_qc_issue_prot,
applied, as part of a jumbo ->cable_detect patch, since this patch
contained changes highly similar to others it was applied alongside.
prev parent reply other threads:[~2007-03-09 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 16:22 [PATCH] pata_ns87410: cable detect method Alan Cox
2007-03-09 12:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F1524D.40705@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).