linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pata_ns87410: cable detect method
@ 2007-03-07 16:22 Alan Cox
  2007-03-09 12:25 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2007-03-07 16:22 UTC (permalink / raw)
  To: akpm, jgarzik, linux-ide

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c linux-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c
--- linux.vanilla-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c	2007-03-06 23:09:46.000000000 +0000
+++ linux-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c	2007-03-06 23:36:02.000000000 +0000
@@ -28,13 +28,13 @@
 #include <linux/libata.h>
 
 #define DRV_NAME "pata_ns87410"
-#define DRV_VERSION "0.4.3"
+#define DRV_VERSION "0.4.6"
 
 /**
  *	ns87410_pre_reset		-	probe begin
  *	@ap: ATA port
  *
- *	Set up cable type and use generic probe init
+ *	Check enabled ports
  */
 
 static int ns87410_pre_reset(struct ata_port *ap)
@@ -47,7 +47,6 @@
 
 	if (!pci_test_config_bits(pdev, &ns87410_enable_bits[ap->port_no]))
 		return -ENOENT;
-	ap->cbl = ATA_CBL_PATA40;
 	return ata_std_prereset(ap);
 }
 
@@ -177,6 +176,7 @@
 	.thaw		= ata_bmdma_thaw,
 	.error_handler	= ns87410_error_handler,
 	.post_internal_cmd = ata_bmdma_post_internal_cmd,
+	.cable_detect	= ata_cable_40wire,
 
 	.qc_prep 	= ata_qc_prep,
 	.qc_issue	= ns87410_qc_issue_prot,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pata_ns87410: cable detect method
  2007-03-07 16:22 [PATCH] pata_ns87410: cable detect method Alan Cox
@ 2007-03-09 12:25 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-03-09 12:25 UTC (permalink / raw)
  To: Alan Cox; +Cc: akpm, linux-ide

Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c linux-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c
> --- linux.vanilla-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c	2007-03-06 23:09:46.000000000 +0000
> +++ linux-2.6.21-rc2-mm2/drivers/ata/pata_ns87410.c	2007-03-06 23:36:02.000000000 +0000
> @@ -28,13 +28,13 @@
>  #include <linux/libata.h>
>  
>  #define DRV_NAME "pata_ns87410"
> -#define DRV_VERSION "0.4.3"
> +#define DRV_VERSION "0.4.6"
>  
>  /**
>   *	ns87410_pre_reset		-	probe begin
>   *	@ap: ATA port
>   *
> - *	Set up cable type and use generic probe init
> + *	Check enabled ports
>   */
>  
>  static int ns87410_pre_reset(struct ata_port *ap)
> @@ -47,7 +47,6 @@
>  
>  	if (!pci_test_config_bits(pdev, &ns87410_enable_bits[ap->port_no]))
>  		return -ENOENT;
> -	ap->cbl = ATA_CBL_PATA40;
>  	return ata_std_prereset(ap);
>  }
>  
> @@ -177,6 +176,7 @@
>  	.thaw		= ata_bmdma_thaw,
>  	.error_handler	= ns87410_error_handler,
>  	.post_internal_cmd = ata_bmdma_post_internal_cmd,
> +	.cable_detect	= ata_cable_40wire,
>  
>  	.qc_prep 	= ata_qc_prep,
>  	.qc_issue	= ns87410_qc_issue_prot,

applied, as part of a jumbo ->cable_detect patch, since this patch 
contained changes highly similar to others it was applied alongside.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-09 12:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-07 16:22 [PATCH] pata_ns87410: cable detect method Alan Cox
2007-03-09 12:25 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).