Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

[Philipp Matthias Hahn]

Hello!

As reported by John Williams and others like in
http://www.mail-archive.com/linux-ide@vger.kernel.org/msg03088.html
I too have a problem with 2.6.20.1 using ata_piix not detecting the
CD-ROM any more. Applying the patch from
http://lkml.org/lkml/2007/2/12/24 did not help, but additionally
applying
http://readlist.com/lists/vger.kernel.org/linux-kernel/45/228948.html
made it work. Here's the relevant extra debugging output:

ata_piix 0000:00:1f.1: version 2.00ac7
ACPI: PCI Interrupt 0000:00:1f.1[A] -> GSI 18 (level, low) -> IRQ 17
PCI: Setting latency timer of device 0000:00:1f.1 to 64
ata1: PATA max UDMA/100 cmd 0x1F0 ctl 0x3F6 bmdma 0x2800 irq 14
ata2: PATA max UDMA/100 cmd 0x170 ctl 0x376 bmdma 0x2808 irq 15
scsi0 : ata_piix
ata1.00: ATA-7, max UDMA/133, 160086528 sectors: LBA
ata1.00: ata1: dev 0 multi count 16
ata1.00: configured for UDMA/100
scsi1 : ata_piix
ata2.00: ATAPI, max UDMA/33
ata2: ata_altstatus take 4us
ata2.00: configured for UDMA/33
scsi 0:0:0:0: Direct-Access     ATA      Maxtor 6Y080L0   YAR4 PQ: 0 ANSI: 5
SCSI device sda: 160086528 512-byte hdwr sectors (81964 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
SCSI device sda: 160086528 512-byte hdwr sectors (81964 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
 sda: sda1 sda2 sda3 < sda5 sda6 sda7 sda8 sda9 sda10 sda11 sda12 > sda4
 sd 0:0:0:0: Attached scsi disk sda
 scsi 1:0:0:0: CD-ROM            LITE-ON  LTR-48246S       SID4 PQ: 0 ANSI: 5
 sr0: scsi3-mmc drive: 230x/48x writer cd/rw xa/form2 cdda tray
 Uniform CD-ROM driver Revision: 3.20
 sr 1:0:0:0: Attached scsi CD-ROM sr0

Something other I should try to get this fixed for 2.6.20.2+?

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de

Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

[Tejun Heo]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Philipp Matthias Hahn wrote:
> Hello!
> 
> As reported by John Williams and others like in
> http://www.mail-archive.com/linux-ide@vger.kernel.org/msg03088.html
> I too have a problem with 2.6.20.1 using ata_piix not detecting the
> CD-ROM any more. Applying the patch from
> http://lkml.org/lkml/2007/2/12/24 did not help, but additionally
> applying
> http://readlist.com/lists/vger.kernel.org/linux-kernel/45/228948.html
> made it work. Here's the relevant extra debugging output:

* Did it work with previous kernels?

* Does applying the attached patch over unpatched 2.6.20.1 fix the problem?

-- 
tejun

[-- Attachment #2: ata_piix-polling-xfer.patch --]
[-- Type: text/x-patch, Size: 650 bytes --]

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index dc42ba1..78e6ac5 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -105,8 +105,10 @@ enum {
 	PIIX_FLAG_AHCI		= (1 << 27), /* AHCI possible */
 	PIIX_FLAG_CHECKINTR	= (1 << 28), /* make sure PCI INTx enabled */
 
-	PIIX_PATA_FLAGS		= ATA_FLAG_SLAVE_POSS,
-	PIIX_SATA_FLAGS		= ATA_FLAG_SATA | PIIX_FLAG_CHECKINTR,
+	PIIX_PATA_FLAGS		= ATA_FLAG_SLAVE_POSS |
+				  ATA_FLAG_SETXFER_POLLING,
+	PIIX_SATA_FLAGS		= ATA_FLAG_SATA | PIIX_FLAG_CHECKINTR |
+				  ATA_FLAG_SETXFER_POLLING,
 
 	/* combined mode.  if set, PATA is channel 0.
 	 * if clear, PATA is channel 1.

Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

[Philipp Matthias Hahn]

Helo Tejun!

On Mon, Mar 05, 2007 at 01:10:10PM +0900, Tejun Heo wrote:
> Philipp Matthias Hahn wrote:
> > As reported by John Williams and others like in
> > http://www.mail-archive.com/linux-ide@vger.kernel.org/msg03088.html
> > I too have a problem with 2.6.20.1 using ata_piix not detecting the
> > CD-ROM any more. Applying the patch from
> > http://lkml.org/lkml/2007/2/12/24 did not help, but additionally
> > applying
> > http://readlist.com/lists/vger.kernel.org/linux-kernel/45/228948.html
> > made it work. Here's the relevant extra debugging output:
> 
> * Did it work with previous kernels?

Previously I was using the old IDE modules just fine, it was only with
2.6.20 that I did the switch to libata and encountered the problem.

> * Does applying the attached patch over unpatched 2.6.20.1 fix the problem?

Yes, it seems to fix it. (testes on top of the first patch mentioned
above, but witheout the second one.).
If I should test it as the sole patche, just mail me again please.

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de

Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

[Tejun Heo]

Philipp Matthias Hahn wrote:
> On Mon, Mar 05, 2007 at 01:10:10PM +0900, Tejun Heo wrote:
>> Philipp Matthias Hahn wrote:
>>> As reported by John Williams and others like in
>>> http://www.mail-archive.com/linux-ide@vger.kernel.org/msg03088.html
>>> I too have a problem with 2.6.20.1 using ata_piix not detecting the
>>> CD-ROM any more. Applying the patch from
>>> http://lkml.org/lkml/2007/2/12/24 did not help, but additionally
>>> applying
>>> http://readlist.com/lists/vger.kernel.org/linux-kernel/45/228948.html
>>> made it work. Here's the relevant extra debugging output:
>> * Did it work with previous kernels?
> 
> Previously I was using the old IDE modules just fine, it was only with
> 2.6.20 that I did the switch to libata and encountered the problem.
> 
>> * Does applying the attached patch over unpatched 2.6.20.1 fix the problem?
> 
> Yes, it seems to fix it. (testes on top of the first patch mentioned
> above, but witheout the second one.).
> If I should test it as the sole patche, just mail me again please.

Yeap, please test it on top of vanilla kernel to verify that the patch
proper fixes the problem.

Thanks.

-- 
tejun

Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

[Philipp Matthias Hahn]

Hello Tejun!

On Tue, Mar 06, 2007 at 12:46:07AM +0900, Tejun Heo wrote:
> Philipp Matthias Hahn wrote:
> > On Mon, Mar 05, 2007 at 01:10:10PM +0900, Tejun Heo wrote:
> > > * Does applying the attached patch over unpatched 2.6.20.1 fix the problem?
> >
> > Yes, it seems to fix it. (testes on top of the first patch mentioned
> > above, but witheout the second one.).
> > If I should test it as the sole patche, just mail me again please.
>
> Yeap, please test it on top of vanilla kernel to verify that the patch
> proper fixes the problem.

Yes, applying only this patch does fix the problem.
Thank you for your support.

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de

Re: [PATA] Failed to set xfermode on LITE-ON LTR-48246S

[Tejun Heo]

Philipp Matthias Hahn wrote:
> Hello Tejun!
> 
> On Tue, Mar 06, 2007 at 12:46:07AM +0900, Tejun Heo wrote:
>> Philipp Matthias Hahn wrote:
>>> On Mon, Mar 05, 2007 at 01:10:10PM +0900, Tejun Heo wrote:
>>>> * Does applying the attached patch over unpatched 2.6.20.1 fix the problem?
>>> Yes, it seems to fix it. (testes on top of the first patch mentioned
>>> above, but witheout the second one.).
>>> If I should test it as the sole patche, just mail me again please.
>> Yeap, please test it on top of vanilla kernel to verify that the patch
>> proper fixes the problem.
> 
> Yes, applying only this patch does fix the problem.
> Thank you for your support.

Okay, it seems we'll have to default to polling SETXFER.  I'll forward
it upstream soon.  Thanks.

-- 
tejun