[PATCH] sata_nv: revert use of notifiers for now

[PATCH] sata_nv: revert use of notifiers for now

[Robert Hancock]

Commit 721449bf0d51213fe3abf0ac3e3561ef9ea7827a added support for using the
ADMA notifier bits to determine which commands to check for completion.
However there have been reports that this causes command timeouts in certain
cases. This is still being investigated. In addition, apparently the notifiers
won't work if ADMA is disabled on the other port as a result of an ATAPI device
being connected, and we don't handle this case properly.

For now, just restore the previous behavior of checking all active commands
to see if they are complete, without relying on the notifiers.

Signed-off-by: Robert Hancock <hancockr@shaw.ca>

--- linux-2.6.21-rc3-git3/drivers/ata/sata_nv.c	2007-03-08 17:15:25.000000000 -0600
+++ linux-2.6.21-rc3-git3edit/drivers/ata/sata_nv.c	2007-03-08 17:19:42.000000000 -0600
@@ -874,8 +874,14 @@
 
 			if (status & (NV_ADMA_STAT_DONE |
 				      NV_ADMA_STAT_CPBERR)) {
-				u32 check_commands = notifier | notifier_error;
+				u32 check_commands;
 				int pos, error = 0;
+
+				if(ata_tag_valid(ap->active_tag))
+					check_commands = 1 << ap->active_tag;
+				else
+					check_commands = ap->sactive;
+
 				/** Check CPBs for completed commands */
 				while ((pos = ffs(check_commands)) && !error) {
 					pos--;

Re: [PATCH] sata_nv: revert use of notifiers for now

[Jeff Garzik]

Robert Hancock wrote:
> Commit 721449bf0d51213fe3abf0ac3e3561ef9ea7827a added support for using the
> ADMA notifier bits to determine which commands to check for completion.
> However there have been reports that this causes command timeouts in 
> certain
> cases. This is still being investigated. In addition, apparently the 
> notifiers
> won't work if ADMA is disabled on the other port as a result of an ATAPI 
> device
> being connected, and we don't handle this case properly.
> 
> For now, just restore the previous behavior of checking all active commands
> to see if they are complete, without relying on the notifiers.
> 
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>

applied to #upstream-fixes