From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix native mode disabled port handling
Date: Fri, 09 Mar 2007 10:02:30 -0500 [thread overview]
Message-ID: <45F17706.9040402@garzik.org> (raw)
In-Reply-To: <20070309104335.GD32687@htj.dyndns.org>
Tejun Heo wrote:
> Disabled port handling in ata_pci_init_native_mode() is slightly
> broken in that it may end up using the wrong port_info. This patch
> updates it such that disables ports are made dummy as done in the
> legacy and other cases.
>
> While at it, fix indentation in ata_resources_present().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-sff.c | 62 ++++++++++++++++++++++++++--------------------
> 1 files changed, 35 insertions(+), 27 deletions(-)
what's the extent of the breakage here?
I would rather push this into #upstream
next prev parent reply other threads:[~2007-03-09 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 10:43 [PATCH] libata: fix native mode disabled port handling Tejun Heo
2007-03-09 12:52 ` Alan Cox
2007-03-09 15:02 ` Jeff Garzik [this message]
2007-03-13 8:06 ` Tejun Heo
2007-04-17 14:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F17706.9040402@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).