From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata: fix native mode disabled port handling Date: Fri, 09 Mar 2007 10:02:30 -0500 Message-ID: <45F17706.9040402@garzik.org> References: <20070309104335.GD32687@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:56794 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992825AbXCIPCd (ORCPT ); Fri, 9 Mar 2007 10:02:33 -0500 In-Reply-To: <20070309104335.GD32687@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: linux-ide@vger.kernel.org Tejun Heo wrote: > Disabled port handling in ata_pci_init_native_mode() is slightly > broken in that it may end up using the wrong port_info. This patch > updates it such that disables ports are made dummy as done in the > legacy and other cases. > > While at it, fix indentation in ata_resources_present(). > > Signed-off-by: Tejun Heo > --- > drivers/ata/libata-sff.c | 62 ++++++++++++++++++++++++++-------------------- > 1 files changed, 35 insertions(+), 27 deletions(-) what's the extent of the breakage here? I would rather push this into #upstream