From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] libata: add support for READ/WRITE LONG Date: Tue, 13 Mar 2007 15:40:37 +0900 Message-ID: <45F64765.10805@gmail.com> References: <3aac340703102322p362998b9labedc13503702d2b@mail.gmail.com> <45F56800.3040104@rtr.ca> <3aac340703121003l43685599t8dbffe6247879a91@mail.gmail.com> <45F5A523.1080500@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.174]:7512 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbXCMGkn (ORCPT ); Tue, 13 Mar 2007 02:40:43 -0400 Received: by ug-out-1314.google.com with SMTP id 44so153938uga for ; Mon, 12 Mar 2007 23:40:42 -0700 (PDT) In-Reply-To: <45F5A523.1080500@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: Jeff Garzik , Vitaliyi , IDE/ATA development list Mark Lord wrote: > The READ/WRITE LONG commands are theoretically obsolete, > but the majority of drives in existance still implement them. > > The WRITE_LONG and WRITE_LONG_ONCE commands are of particular > interest for fault injection testing -- eg. creating "media errors" > at specific locations on a disk. > > The fussy bit is that these commands require a non-standard > sector size, usually 520 bytes instead of 512. > > This patch adds support to libata for READ/WRITE LONG commands > issued via SG_IO/ATA_16. > > This patch was generated against a 2.6.21-rc3-git7 base: I think it would be better if this comes in two patches. One to add qc->sect_size and convert all users of ATA_SECT_SIZE to qc->sect_size and the other one to implement READ/WRITE LONG. Another question is whether this needs to be included into mainline. This is definitely useful but it is mostly for debugging/testing. Hmmm... But we're gonna need qc->sect_size anyway for devices with larger sector sizes and overhead for supporting READ/WRITE LONG is nearly nill, so I'm voting for inclusion. Thanks. -- tejun