From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert Lee Subject: Re: IOMEGA IDE ZIP (ATAPI) drive Date: Sat, 17 Mar 2007 11:19:44 +0800 Message-ID: <45FB5E50.4030006@tw.ibm.com> References: <45F7DA2B0200002D0001585E@emea5-mh.id5.novell.com> <45F7E34B.6020206@gmail.com> <45F7F90B.6070709@rtr.ca> <45F7FD13.2070907@gmail.com> <45F9C4B2.20906@rtr.ca> <45FAAA22.7060000@tw.ibm.com> <45FAB418.2070402@rtr.ca> <45FAD204.2060700@tw.ibm.com> <45FB095F.1020009@rtr.ca> Reply-To: albertl@mail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:51588 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933102AbXCQDUA (ORCPT ); Fri, 16 Mar 2007 23:20:00 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id l2H3Jxg5026439 for ; Fri, 16 Mar 2007 23:19:59 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l2H3Jxrb053740 for ; Fri, 16 Mar 2007 21:19:59 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l2H3Jvo7016414 for ; Fri, 16 Mar 2007 21:19:58 -0600 In-Reply-To: <45FB095F.1020009@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: albertl@mail.com, Tejun Heo , Stanislav Brabec , jeff@garzik.org, bzolnier@gmail.com, alan@lxorguk.ukuu.org.uk, paul@paulbristow.net, chrubis@suse.cz, linux-ide@vger.kernel.org Mark Lord wrote: > Albert Lee wrote: > >> .. >> Maybe we can wait a moment and give the slow ATAPI devices some time >> to set DRQ. >> Could you please try if the attached patch works, thanks. >> -- >> albert >> >> --- linux-2.6.20.3/drivers/ata/libata-core.c 2007-03-15 >> 18:03:27.000000000 +0800 >> +++ linux-2.6.20.3-mod2/drivers/ata/libata-core.c 2007-03-17 >> 01:12:53.000000000 +0800 >> @@ -4384,6 +4384,19 @@ fsm_start: >> */ >> poll_next = (qc->tf.flags & ATA_TFLAG_POLLING); >> >> + /* wait for some slow ATAPI devices to set DRQ */ >> + if (unlikely((status & ATA_DRQ) == 0) && >> + is_atapi_taskfile(&qc->tf)) { >> + int max = 100; >> + >> + do { >> + udelay(10); >> + status = ata_chk_status(ap); >> + max--; >> + ata_port_printk(ap, KERN_ERR, "wait for DRQ %d\n", >> 100-max); >> + } while (((status & ATA_DRQ) == 0) && (max > 0)); >> + } >> + >> /* check device status */ >> if (unlikely((status & ATA_DRQ) == 0)) { >> /* handle BSY=0, DRQ=0 as error */ >> > > I patched the above in, and it was NEVER hit. Do you mean no "wait for DRQ" messages at all? Is the HSM violation still seen? -- albert