From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Vroon Subject: Re: [PATCH 2.6.22] Add LED trigger to libata core Date: Mon, 19 Mar 2007 12:12:52 +0000 Message-ID: <45FE7E44.6040805@gentoo.org> References: <20070318170605.3751D5B80F1@ganymede.vroon.org> <45FE14BD.5090701@gmail.com> <20070319124616.2fb7494b@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from ganymede.vroon.org ([195.66.242.11]:42473 "EHLO ganymede.vroon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933238AbXCSMgp (ORCPT ); Mon, 19 Mar 2007 08:36:45 -0400 In-Reply-To: <20070319124616.2fb7494b@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: Tejun Heo , Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Alan Cox wrote: > Gak. I'd rather it stayed out of ata_qc_issue() which is a critical path > for performance. Our command issu is already too heavy and not all > controllers have queueing to absorb that. How many controllers actually > need this hook and can we not have ata_qc_issue_with_led() helpers for > them ? We're talking about just sata_svw (Apple K2) right now. I'll have a go at implementing it conditionally like you suggested. Consider the patch withdrawn for now. Regards, Tony V. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFF/n5Dp5vW4rUFj5oRCJbzAJ4+rkkqdA21If03WLFT6jquX+np+QCgwSGX UV41rt4ZimQvf0kXLwkuFqo= =Ar6p -----END PGP SIGNATURE-----