From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Nate Riffe <inkblot@movealong.org>,
linux-ide@vger.kernel.org, kernel@vger.kernel.org
Subject: Re: [PATCH] sata_inic162x: kill double region requests
Date: Mon, 19 Mar 2007 12:04:21 -0400 [thread overview]
Message-ID: <45FEB485.7050909@garzik.org> (raw)
In-Reply-To: <20070315165942.GC15600@htj.dyndns.org>
Tejun Heo wrote:
> Regions are requested twice during initialization causing the second
> one to fail. This is regression introduced during iomap conversion.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Nate, this should fix it. But LBA48 support is broken on the
> controller.
>
> diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
> index dcf5fe5..11c3079 100644
> --- a/drivers/ata/sata_inic162x.c
> +++ b/drivers/ata/sata_inic162x.c
> @@ -674,10 +674,6 @@ static int inic_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> if (rc)
> return rc;
>
> - rc = pci_request_regions(pdev, DRV_NAME);
> - if (rc)
> - return rc;
> -
> rc = pcim_iomap_regions(pdev, 0x3f, DRV_NAME);
> if (rc)
> return rc;
applied
prev parent reply other threads:[~2007-03-19 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070310205636.GA14704@movealong.org>
[not found] ` <45F4F483.9080302@gmail.com>
2007-03-12 22:06 ` sata_inic162x card init trouble Nate Riffe
2007-03-15 16:59 ` [PATCH] sata_inic162x: kill double region requests Tejun Heo
2007-03-15 18:07 ` Alan Cox
2007-03-16 21:00 ` Nate Riffe
2007-03-19 16:04 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FEB485.7050909@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=inkblot@movealong.org \
--cc=kernel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).