From: Tejun Heo <htejun@gmail.com>
To: Tony Vroon <chainsaw@gentoo.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core
Date: Tue, 20 Mar 2007 12:38:49 +0900 [thread overview]
Message-ID: <45FF5749.6010407@gmail.com> (raw)
In-Reply-To: <20070319214907.094B65B80F2@ganymede.vroon.org>
Tony Vroon wrote:
> The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/
> Apple K2 driver. Used by the IDE LED trigger on G5 towers.
> Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox.
Just two comments.
1. IMHO, ata_qc_issue_prot_ledtrigger() without 'with' is good enough.
This is just my personal preference. Feel free to ignore it.
2. Patch #1 and #2 should be merged. They're one logical change of
adding ata_qc_issue_prot_with_ledtrigger(). Patch #3 is a logically
separate change of using it, but unless it's a wide conversion,
implementing something and using something can be merged. So, please
merge #1 and #2 and possibly #3.
Thanks.
--
tejun
prev parent reply other threads:[~2007-03-20 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 21:49 [PATCH 2.6.22 3/3] Add LED trigger to libata core Tony Vroon
2007-03-20 3:38 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FF5749.6010407@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chainsaw@gentoo.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).