* [PATCH 2.6.22 3/3] Add LED trigger to libata core
@ 2007-03-19 21:49 Tony Vroon
2007-03-20 3:38 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Tony Vroon @ 2007-03-19 21:49 UTC (permalink / raw)
To: Jeff Garzik; +Cc: htejun, alan, linux-ide, linux-kernel
The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/
Apple K2 driver. Used by the IDE LED trigger on G5 towers.
Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox.
Signed-off-by: Tony Vroon <chainsaw@gentoo.org>
--- linux-2.6/drivers/ata/sata_svw.c.orig 2007-03-19 20:58:20.000000000 +0000
+++ linux-2.6/drivers/ata/sata_svw.c 2007-03-19 20:58:35.000000000 +0000
@@ -348,7 +348,7 @@
.bmdma_stop = ata_bmdma_stop,
.bmdma_status = ata_bmdma_status,
.qc_prep = ata_qc_prep,
- .qc_issue = ata_qc_issue_prot,
+ .qc_issue = ata_qc_issue_prot_with_ledtrigger,
.data_xfer = ata_data_xfer,
.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core
2007-03-19 21:49 [PATCH 2.6.22 3/3] Add LED trigger to libata core Tony Vroon
@ 2007-03-20 3:38 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2007-03-20 3:38 UTC (permalink / raw)
To: Tony Vroon; +Cc: Jeff Garzik, alan, linux-ide, linux-kernel
Tony Vroon wrote:
> The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/
> Apple K2 driver. Used by the IDE LED trigger on G5 towers.
> Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox.
Just two comments.
1. IMHO, ata_qc_issue_prot_ledtrigger() without 'with' is good enough.
This is just my personal preference. Feel free to ignore it.
2. Patch #1 and #2 should be merged. They're one logical change of
adding ata_qc_issue_prot_with_ledtrigger(). Patch #3 is a logically
separate change of using it, but unless it's a wide conversion,
implementing something and using something can be merged. So, please
merge #1 and #2 and possibly #3.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-20 3:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-19 21:49 [PATCH 2.6.22 3/3] Add LED trigger to libata core Tony Vroon
2007-03-20 3:38 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).