Re: [PATCH 2/3] sd: implement START/STOP management

[Tejun Heo <htejun@gmail.com>]

James Bottomley wrote:
> On Wed, 2007-03-21 at 00:13 +0900, Tejun Heo wrote:
>> Implement SBC START/STOP management.  sdev->mange_start_stop is added.
>> When it's set to one, sd STOPs the device on suspend and shutdown and
>> STARTs it on resume.  sdev->manage_start_stop defaults is in sdev
>> instead of scsi_disk cdev to allow ->slave_config() override the
>> default configuration but is exported under scsi_disk sysfs node as
>> sdev->allow_restart is.
>>
>> When manage_start_stop is zero (the default value), this patch doesn't
>> introduce any behavior change.
> 
> I have this in scsi-misc-2.6.  There was a minor space before tab no-no
> which git complained about (and I fixed).  Unfortunately, there's a
> pretty major merge conflict with prior sd.c patches in scsi-misc-2.6.
> I've merged and fixed this but it's going to create a bit of a
> difficulty for applying the libata pieces.

I got too comfortable with libata-dev#upstream and forgot to verify
patches against scsi-misc-2.6.  Sorry about that.  If you don't have
objection against the content, I'll resubmit the SCSI part against
scsi-misc-2.6.  Once it's in scsi-misc-2.6, we can pull it into
libata-dev#upstream and do the libata part there.  As the SCSI change
doesn't break libata, they can be done separately.

Thanks.

-- 
tejun