From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver Date: Wed, 21 Mar 2007 16:32:32 +0900 Message-ID: <4600DF90.3030902@gmail.com> References: <45DD2EC9.4050403@shaw.ca> <45DF67C4.8090802@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.171]:41077 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932738AbXCUHck (ORCPT ); Wed, 21 Mar 2007 03:32:40 -0400 Received: by ug-out-1314.google.com with SMTP id 44so195669uga for ; Wed, 21 Mar 2007 00:32:39 -0700 (PDT) In-Reply-To: <45DF67C4.8090802@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Robert Hancock , linux-kernel , linux-ide@vger.kernel.org, Andrew Morton , Jens Axboe , "Eric D. Mudama" , Mathieu.Berard@crans.org Jeff Garzik wrote: > Robert Hancock wrote: >> This patch adds in some NCQ blacklist entries taken from the Silicon >> Image Windows drivers' .inf files for the 3124 and 3132 controllers. >> These entries were marked as ""DisableSataQueueing". Assume these are >> in their blacklist for a reason and disable NCQ on these drives. >> >> Signed-off-by: Robert Hancock >> >> --- linux-2.6.21-rc1edit/drivers/ata/libata-core.c.prev 2007-02-21 >> 22:23:05.000000000 -0600 >> +++ linux-2.6.21-rc1edit/drivers/ata/libata-core.c 2007-02-21 >> 22:25:44.000000000 -0600 >> @@ -3269,6 +3269,13 @@ static const struct ata_blacklist_entry >> /* Devices with NCQ limits */ >> >> + /* The following blacklist entries are taken from the Windows >> + driver .inf files for the Silicon Image 3124 and 3132. */ >> + { "Maxtor 7B250S0", "BANC1B70", ATA_HORKAGE_NONCQ, }, >> + { "HTS541060G9SA00", "MB3OC60D", ATA_HORKAGE_NONCQ, }, >> + { "HTS541080G9SA00", "MB4OC60D", ATA_HORKAGE_NONCQ, }, >> + { "HTS541010G9SA00", "MBZOC60D", ATA_HORKAGE_NONCQ, }, There was a recent regression report on ahci + HTS541010G9SA00 from Mathieu Berard (cc'd). NCQ + device initiated link power saving (which, BTW, got activated by executing _GTF. surprise!) combination seems broken. I know that ahci controllers (at least ich6m, ich7 and ich8) work with device initiated PS, so it's most likely the disk that's malfunctioning. This and the fact sata_sil24 windows driver blacklists them make me think those HTS5410s should be added to our blacklist too. What do you think? Mathieu, just to be sure, can you post the result of 'hdparm -I /dev/sdX' and 'lspci -nn'? Thanks. -- tejun