From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, xhejtman@mail.muni.cz
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: IDENTIFY backwards for drive side cable detection
Date: Fri, 23 Mar 2007 00:44:09 +0900 [thread overview]
Message-ID: <4602A449.2070009@gmail.com> (raw)
In-Reply-To: <20070322143712.64551edf@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Thu, 22 Mar 2007 22:24:19 +0900
> Tejun Heo <htejun@gmail.com> wrote:
>
>> For drive side cable detection to work correctly, drives need to be
>> identified backwards such that the slave device releases PDIAG- before
>> the mater drive tries to detect cable type. ata_bus_probe() was fixed
>> by commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c but the new EH path
>> wasn't fixed. This patch makes new EH path do IDENTIFY backwards.
>>
>> ata_dev_configure() for new devices are still performed master first.
>> This is to keep the detection messages in forward order.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> Acked-by: Alan Cox <alan@redhat.com>
>
> Why do we have two implementations of the same code ?
ata_bus_probe() is scheduled to be killed once all old-EH code is
removed. That's the old probe path.
--
tejun
prev parent reply other threads:[~2007-03-22 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 13:24 [PATCH libata-dev#upstream-fixes] libata: IDENTIFY backwards for drive side cable detection Tejun Heo
2007-03-22 14:37 ` Alan Cox
2007-03-22 15:44 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4602A449.2070009@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=xhejtman@mail.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).