From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan <alan@lxorguk.ukuu.org.uk>, Tejun Heo <htejun@gmail.com>,
Len Brown <lenb@kernel.org>,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Subject: Re: ATA ACPI (was Re: Linux 2.6.21-rc5)
Date: Tue, 27 Mar 2007 14:48:18 -0400 [thread overview]
Message-ID: <460966F2.4010307@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703271006340.6730@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> On Tue, 27 Mar 2007, Jeff Garzik wrote:
>> FWIW, I'm still leaning towards disabling libata ACPI support by default for
>> 2.6.21.
>
> Hey, I'm not going to argue against anything that says "disable ACPI". Of
> *course* it should be disabled if there aren't thousands of machines that
> are in user hands that actually need it (and none that regress).
It's required to access data at all (BIOS-supplied password [un]locks
disk), in a small minority of configurations. It's strongly suggested
for reliable suspend/resume, particularly on laptops, where libata ACPI
support fixes some suspend/resume problems.
Some BIOSen also want to apply drive+board-specific errata workarounds.
That's OK, but ideally we should know about those in the kernel.
"none that regress" is the problem though. Buggy tables, unexercised
ACPI code paths, and in a few cases unexpected post-ACPI
drive/controller behavior expose regressions.
> Anybody want to send me a patch?
Since everybody is OK with my plan, I'll send one today along with the
rest of the post-vacation 2.6.21-rc bug fixes.
Jeff
next prev parent reply other threads:[~2007-03-27 18:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0703251559560.6730@woody.linux-foundation.org>
2007-03-27 1:59 ` [2/5] 2.6.21-rc5: known regressions Adrian Bunk
2007-03-28 19:46 ` Laurent Riffard
2007-03-29 19:02 ` Fabio Comolli
2007-03-27 1:59 ` [4/5] " Adrian Bunk
2007-03-27 5:51 ` ATA ACPI (was Re: Linux 2.6.21-rc5) Jeff Garzik
2007-03-27 5:54 ` Tejun Heo
2007-03-27 21:32 ` Pavel Machek
2007-03-28 9:51 ` Tejun Heo
2007-03-27 17:07 ` Linus Torvalds
2007-03-27 18:48 ` Jeff Garzik [this message]
2007-03-30 21:32 ` [1/4] 2.6.21-rc5: known regressions (v2) Adrian Bunk
2007-03-30 21:38 ` Greg KH
2007-03-31 0:23 ` Michal Jaegermann
2007-03-31 15:01 ` Adrian Bunk
2007-03-31 16:42 ` Michal Jaegermann
2007-03-30 21:32 ` [3/4] " Adrian Bunk
2007-03-31 2:52 ` Jeff Chua
2007-03-31 18:19 ` 2.6.21-rc5: known regressions with patches (v2) Adrian Bunk
2007-04-03 4:05 ` [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver (v2) Robert Hancock
2007-04-03 4:13 ` Tejun Heo
2007-04-04 6:09 ` Jeff Garzik
2007-04-04 14:26 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460966F2.4010307@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=kristen.c.accardi@intel.com \
--cc=lenb@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).