From: Tejun Heo <htejun@gmail.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: gregkh@suse.de, hugh@veritas.com, dmitry.torokhov@gmail.com,
oneukum@suse.de, maneesh@in.ibm.com, rpurdie@rpsys.net,
James.Bottomley@SteelEye.com, Jeff Garzik <jgarzik@pobox.com>,
lkml <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [RFD driver-core] Lifetime problems of the current driver model
Date: Fri, 30 Mar 2007 22:58:39 +0900 [thread overview]
Message-ID: <460D178F.4000500@gmail.com> (raw)
In-Reply-To: <20070330154042.4c7deb72@gondolin.boeblingen.de.ibm.com>
Cornelia Huck wrote:
> On Fri, 30 Mar 2007 22:19:52 +0900,
> Tejun Heo <htejun@gmail.com> wrote:
>
>>> Shouldn't getting/putting the module refcount be solely done in
>>> kobject.c? Grab the module reference when the kobject is created and
>>> release the module reference in kobject_cleanup() after the release
>>> function has been called. This doesn't make kobject_get() heavier, and
>>> it ensures we don't delete the module until after the last kobject it is
>>> supposed to clean up has been released.
>> If we do that, we wouldn't be able to unload a module if there is any
>> kobject referencing it even when the node has no openers, so no easy way
>> out there. :-(
>
> But we must not unload the module when there is still a kobject around
> referencing a release function in the module, or we will oops if the
> kobject is finally released. If needed, the module must clean up its
> kobjects in its exit function.
It's a little bit more convoluted than that. Module reference count of
zero doesn't indicate that there is no one referencing the module. It
just means that the module can be unloaded. ie. There still can be any
number of kobjects with release function backed by the module but as
long as all of them can be deleted and released by module exit function,
the module is unloadable at that point.
IOW, module reference count does not count number of objects depending
on the module. It counts the number of active usages of those objects.
--
tejun
next prev parent reply other threads:[~2007-03-30 13:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <460CDBA6.5030608@gmail.com>
2007-03-30 12:29 ` [RFD driver-core] Lifetime problems of the current driver model James Bottomley
2007-03-30 13:15 ` Dmitry Torokhov
2007-03-30 13:38 ` Tejun Heo
[not found] ` <460D12B8.6050101@gmail.com>
2007-03-30 17:41 ` Greg KH
2007-03-30 18:19 ` James Bottomley
2007-04-01 19:59 ` Tejun Heo
2007-04-02 9:20 ` Cornelia Huck
2007-04-02 15:34 ` Cornelia Huck
2007-04-03 3:08 ` Tejun Heo
2007-04-02 9:33 ` Greg KH
2007-04-02 12:10 ` Maneesh Soni
2007-04-02 19:33 ` Luben Tuikov
[not found] ` <d120d5000703300615y7b367d82hb42f1c58ca8a6328@mail.gmail.com>
2007-03-30 17:58 ` James Bottomley
2007-03-30 18:18 ` Dmitry Torokhov
2007-03-30 13:19 ` Cornelia Huck
2007-03-30 13:19 ` Tejun Heo
2007-03-30 13:40 ` Cornelia Huck
2007-03-30 13:58 ` Tejun Heo [this message]
2007-03-30 14:52 ` Cornelia Huck
2007-03-30 15:08 ` Tejun Heo
2007-03-30 19:31 ` Cornelia Huck
2007-03-31 3:12 ` Tejun Heo
2007-03-31 3:15 ` Tejun Heo
2007-03-31 16:08 ` Cornelia Huck
2007-03-31 16:14 ` Tejun Heo
2007-04-02 19:24 ` Luben Tuikov
2007-03-30 17:38 ` Greg KH
2007-03-30 9:43 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460D178F.4000500@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=hugh@veritas.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=oneukum@suse.de \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).