From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <mlord@pobox.com>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
Date: Sat, 31 Mar 2007 12:36:05 +0900 [thread overview]
Message-ID: <460DD725.1040607@gmail.com> (raw)
In-Reply-To: <460D8510.1050102@pobox.com>
Mark Lord wrote:
> Ideally, this would go into linux-2.6.21.
>
> Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21
> 13:35:02.000000000 -0400
> +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400
> @@ -333,7 +333,7 @@
> scsi_cmd[8] = args[3];
> scsi_cmd[10] = args[4];
> scsi_cmd[12] = args[5];
> - scsi_cmd[13] = args[6] & 0x0f;
> + scsi_cmd[13] = args[6] & 0x4f;
> scsi_cmd[14] = args[0];
>
> /* Good values for timeout and retries? Values below
IDE seems to be just overriding devsel (0x10) and leaving the rest
alone. Maybe we should do (args[6] & ~0x10) here? Or is it safer this way?
Thanks.
--
tejun
next prev parent reply other threads:[~2007-03-31 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070330205938.984247529@mini.kroah.org>
[not found] ` <20070330210659.GK29450@kroah.com>
2007-03-30 21:45 ` libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK Mark Lord
2007-03-31 3:36 ` Tejun Heo [this message]
2007-03-31 16:55 ` Mark Lord
2007-03-31 17:05 ` Tejun Heo
2007-04-04 6:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460DD725.1040607@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).