From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Alan Cox <alan@redhat.com>, Jeff Garzik <jgarzik@pobox.com>,
Ric Wheeler <ric@emc.com>
Subject: Re: [PATCH] 2.6.21 fix lba48 bug in libata fill_result_tf()
Date: Tue, 03 Apr 2007 20:54:04 +0900 [thread overview]
Message-ID: <4612405C.1000005@gmail.com> (raw)
In-Reply-To: <4611792C.1040404@rtr.ca>
Mark Lord wrote:
> Mark Lord wrote:
>>
>> This patch corrects fill_result_tf() so that the flags
>> get copied to result_tf before they are used by tf_read().
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
>> ---
>> --- linux/drivers/ata/libata-core.c.orig 2007-03-21
>> 12:46:06.000000000 -0400
>> +++ linux/drivers/ata/libata-core.c 2007-04-02 16:16:28.000000000
>> -0400
>> @@ -4763,8 +4763,8 @@
>> {
>> struct ata_port *ap = qc->ap;
>>
>> - ap->ops->tf_read(ap, &qc->result_tf);
>> qc->result_tf.flags = qc->tf.flags;
>> + ap->ops->tf_read(ap, &qc->result_tf);
>> }
>>
>> /**
>>
>
> If I understand this correctly, the impact of (not patching) this
> is that error-handling for LBA48 accesses is broken. Right, Tejun?
Yes, you're right. Thanks for fixing this.
Acked-by: Tejun Heo <htejun@gmail.com>
--
tejun
next prev parent reply other threads:[~2007-04-03 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 20:20 [PATCH] 2.6.21 fix lba48 bug in libata fill_result_tf() Mark Lord
2007-04-02 21:44 ` Mark Lord
2007-04-03 11:54 ` Tejun Heo [this message]
2007-04-03 15:29 ` Mark Lord
2007-04-04 6:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4612405C.1000005@gmail.com \
--to=htejun@gmail.com \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=ric@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).