* [PATCH libata#upstream 1/2] sata_promise: add missing cable_detect hooks
@ 2007-03-11 20:19 Mikael Pettersson
2007-04-04 5:43 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2007-03-11 20:19 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide
The recent change which moved cable detection from
pdc_pre_reset() to the new ->cable_detect hook only
added the hook for SATAII chips, leaving SATAI chips
and the 20619 without the hook. Fixed by this patch.
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
---
drivers/ata/sata_promise.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.21-rc3/drivers/ata/sata_promise.c.~1~ 2007-03-11 18:44:04.000000000 +0100
+++ linux-2.6.21-rc3/drivers/ata/sata_promise.c 2007-03-11 18:44:56.000000000 +0100
@@ -45,7 +45,7 @@
#include "sata_promise.h"
#define DRV_NAME "sata_promise"
-#define DRV_VERSION "2.01"
+#define DRV_VERSION "2.02"
enum {
@@ -194,6 +194,7 @@ static const struct ata_port_operations
.thaw = pdc_thaw,
.error_handler = pdc_error_handler,
.post_internal_cmd = pdc_post_internal_cmd,
+ .cable_detect = pdc_cable_detect,
.data_xfer = ata_data_xfer,
.irq_handler = pdc_interrupt,
.irq_clear = pdc_irq_clear,
@@ -220,6 +221,7 @@ static const struct ata_port_operations
.thaw = pdc_thaw,
.error_handler = pdc_error_handler,
.post_internal_cmd = pdc_post_internal_cmd,
+ .cable_detect = pdc_cable_detect,
.data_xfer = ata_data_xfer,
.irq_handler = pdc_interrupt,
.irq_clear = pdc_irq_clear,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH libata#upstream 1/2] sata_promise: add missing cable_detect hooks
2007-03-11 20:19 [PATCH libata#upstream 1/2] sata_promise: add missing cable_detect hooks Mikael Pettersson
@ 2007-04-04 5:43 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-04-04 5:43 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-ide
Mikael Pettersson wrote:
> The recent change which moved cable detection from
> pdc_pre_reset() to the new ->cable_detect hook only
> added the hook for SATAII chips, leaving SATAI chips
> and the 20619 without the hook. Fixed by this patch.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
> drivers/ata/sata_promise.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletion(-)
applied 1-2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-04 5:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-11 20:19 [PATCH libata#upstream 1/2] sata_promise: add missing cable_detect hooks Mikael Pettersson
2007-04-04 5:43 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).